Selector playground omits quotes for preferred data- attribute selectors

[silversteez]

Current behavior:

When using selector playground to select elements with preferred data attributes (data-cy, data-test, data-testid), the provided selector is missing quotes around the value. The selector then fails to .get() the desired element during test.

Any other data- attribute works correctly.

Desired behavior:

Preferred data- attribute selectors should have quotes around the value

Steps to reproduce:

Use selector playground to select any element with a data-test="whatever" attribute

Versions

Cypress 3.0.1, Mac Os 10.12.5, Electron 59

[brian-mann]

I believe there is a check that tests whether or not the quotes are necessary - and only conditionally adds them.

Can you provide an example / code / screenshot / whatever to show the behavior you're describing?

[silversteez]

Here are a few screenshots of the DOM and results offered by selector playground:

Any non-preferred data- attribute includes the quotes:

[chrisbreiding]

Looks like this is only an issue in electron. Chrome has no problem with cy.get('data-test=add-attribute-button]'). @brian-mann Do you recall the reason for this change? Any reason not to quote all attribute values?