Skip to content

fix: wrap playground selectors in double quotes if not included #18442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 18, 2021
Merged

fix: wrap playground selectors in double quotes if not included #18442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4b99ece
issue-1884: wrap playground selectors in double quotes if they're not…
Manuel-Suarez-Abascal Oct 11, 2021
2a9d496
issue-1884: fix some edges cases aroudn the wrapping of double quotes…
Manuel-Suarez-Abascal Oct 11, 2021
c97e619
Merge branch 'develop' into issue-1884
Manuel-Suarez-Abascal Oct 16, 2021
f56684e
fix: selector playground & update from develop
Manuel-Suarez-Abascal Oct 16, 2021
9196c57
fix: Merge branch 'issue-1884' of https://github.com/Manuel-Suarez-Ab…
Manuel-Suarez-Abascal Oct 16, 2021
b93a4aa
fix: selector playground & update from develop
Manuel-Suarez-Abascal Oct 16, 2021
bff3315
fix: Merge branch 'issue-1884' of https://github.com/Manuel-Suarez-Ab…
Manuel-Suarez-Abascal Oct 16, 2021
c1235d2
Merge branch 'develop' into issue-1884
Manuel-Suarez-Abascal Oct 23, 2021
e95504d
Merge branch 'develop' into issue-1884
chrisbreiding Nov 17, 2021
e692580
Revert "issue-1884: wrap playground selectors in double quotes if the…
chrisbreiding Nov 17, 2021
b86e960
bump @cypress/unique-selector to 0.4.3
chrisbreiding Nov 17, 2021
fe0519e
bump @cypress/unique-selector to 0.4.4
chrisbreiding Nov 17, 2021
f164d98
Merge branch 'develop' into issue-1884
emilyrohrbough Nov 17, 2021
fa1e77c
Merge branch 'develop' into issue-1884
chrisbreiding Nov 18, 2021
fcabfee
Merge branch 'develop' into issue-1884
Manuel-Suarez-Abascal Nov 18, 2021
47efb42
update tests
chrisbreiding Nov 18, 2021
bf90e2f
Merge branch 'issue-1884' of github.com:Manuel-Suarez-Abascal/cypress…
chrisbreiding Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/driver/cypress/integration/cypress/selector_playground_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ describe('src/cypress/selector_playground', () => {
selectorPriority: ['data-foo'],
})

expect(SelectorPlayground.getSelector($div)).to.eq('[data-foo=bar]')
expect(SelectorPlayground.getSelector($div)).to.eq('[data-foo="bar"]')

SelectorPlayground.defaults({
onElement ($el) {
Expand All @@ -148,7 +148,7 @@ describe('src/cypress/selector_playground', () => {
},
})

expect(SelectorPlayground.getSelector($div)).to.eq('[data-foo=bar]')
expect(SelectorPlayground.getSelector($div)).to.eq('[data-foo="bar"]')
})
})
})
2 changes: 1 addition & 1 deletion packages/driver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@babel/code-frame": "7.8.3",
"@cypress/bower-kendo-ui": "0.0.2",
"@cypress/sinon-chai": "2.9.1",
"@cypress/unique-selector": "0.4.2",
"@cypress/unique-selector": "0.4.4",
"@cypress/webpack-preprocessor": "0.0.0-development",
"@cypress/what-is-circular": "1.0.1",
"@packages/config": "0.0.0-development",
Expand Down
6 changes: 3 additions & 3 deletions packages/runner/cypress/integration/studio.record.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,17 +566,17 @@ describe('studio record', () => {
getFrame().find('p').click()

verifyCommandLog(1, {
selector: '[data-cy=btn1]',
selector: '[data-cy="btn1"]',
name: 'click',
})

verifyCommandLog(2, {
selector: '[data-test=btn2]',
selector: '[data-test="btn2"]',
name: 'click',
})

verifyCommandLog(3, {
selector: '[data-testid=btn3]',
selector: '[data-testid="btn3"]',
name: 'click',
})

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2495,10 +2495,10 @@
resolved "https://registry.yarnpkg.com/@cypress/sinon-chai/-/sinon-chai-2.9.1.tgz#1705c0341bc286740979b1b1cac89b7f5d34d6bc"
integrity sha512-qwFQ1urghF3mv7CFSDw/LEqIQP12qqKLuW7p6mXR92HP5fPNlgNiZVITWVsupDg7JpOEKfeRTVearo9mkk/5eg==

"@cypress/[email protected].2":
version "0.4.2"
resolved "https://registry.yarnpkg.com/@cypress/unique-selector/-/unique-selector-0.4.2.tgz#ac4f12d2a0306e9d8ac1d49a12ad40dfbf2f1aeb"
integrity sha512-eTzoodaUESR8lAJkgvTVnF9bs7M1P4aiDsH4jbywcszb3IjJRLLvrMRZp7VDWID33to79EiqyfOudOzXXpuJjQ==
"@cypress/[email protected].4":
version "0.4.4"
resolved "https://registry.yarnpkg.com/@cypress/unique-selector/-/unique-selector-0.4.4.tgz#5e14be46ba5d7a4dad8eda07c0fd431a99227d83"
integrity sha512-hAvSShXUzIRpYDJNIC/OoQA/8stGcYGG2surkY/pMVElqWmAcfccjOWYbuii/ktP8zqUcPzxWKWCuFauJYWEfQ==
dependencies:
css.escape "^1.5.1"

Expand Down