Skip to content

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Nov 9, 2021

User facing changelog

Screen.Recording.2021-11-09.at.5.56.47.PM.mov

Additional changes

  • When the help link of a modal is forced to empty, I hide the help link.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 9, 2021

Thanks for taking the time to open a PR!

@elevatebart elevatebart marked this pull request as ready for review November 9, 2021 23:59
@cypress
Copy link

cypress bot commented Nov 10, 2021



Test summary

18646 3 216 7Flakiness 7


Run details

Project cypress
Status Failed
Commit 4d714d6
Started Nov 10, 2021 12:06 AM
Ended Nov 10, 2021 12:18 AM
Duration 12:02 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: 5x-driver-electron (Linux, Electron )
commands/net_stubbing_spec.ts Failed
1 network stubbing > intercepting request > should delay the same amount on every response
commands/assertions_spec.js Failed
1 ... > rejects any element not in the document
Run group: 2x-desktop-gui (Linux, Electron )
settings_spec.js Failed
1 Settings > file preference panel > loads preferred editor and available editors

Flakiness

net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single response using "alias.response"
3 network stubbing > waiting and aliasing > can timeout incrementally waiting on responses
navigation_spec.js Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
assertions_spec.js Flakiness
1 ... > rejects any element not in the document
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@JessicaSachs JessicaSachs merged commit 2ffcf08 into unified-desktop-gui Nov 10, 2021
@JessicaSachs JessicaSachs deleted the feat/key-bindings branch November 10, 2021 01:20
tgriesser added a commit that referenced this pull request Nov 14, 2021
* unified-desktop-gui:
  refactor: move currentProject to root data (#18834)
  chore: additional app shape cleanup (#18826)
  feat(useCollapsibleTree): adding support for building expandable and collapsible trees (#18860)
  feat: reconcile terminal command components (#18853)
  feat: setup keyboard shortcuts modal (#18864)
  feat: inline spec list header (#18863)
  feat: Runner spec list (#18821)
tgriesser added a commit that referenced this pull request Nov 14, 2021
…e-data-clean-refactor

* tgriesser/chore/e2e-data-clean:
  refactor: move currentProject to root data (#18834)
  chore: additional app shape cleanup (#18826)
  feat(useCollapsibleTree): adding support for building expandable and collapsible trees (#18860)
  feat: reconcile terminal command components (#18853)
  feat: setup keyboard shortcuts modal (#18864)
  feat: inline spec list header (#18863)
  feat: Runner spec list (#18821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants