feat(app): add tree list to spec page #18913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
requested review from
ZachJW34,
ImCesar,
elevatebart,
JessicaSachs and
marktnoonan
lmiller1990
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
I tweaked a few styles, mostly for the icon alignment. Rest looks good, LGTM! |
ZachJW34
approved these changes
Nov 15, 2021
lmiller1990
added a commit
that referenced
this pull request
Nov 16, 2021
* feat: create spec tree * improve types * feat(app): add tree list to spec page (#18913) Co-authored-by: Zachary Williams <[email protected]> * address comments * update style * better types * remove unused code * remove old code Co-authored-by: Lachlan Miller <[email protected]> Co-authored-by: Zachary Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting:
feat-spec-list-branch(has PR: #18901)Uses the spec tree code from the ^ branch to also show a tree view on the main spec page.
Note: some tiny imperfections, like the control to toggle between tree and flat view is black/white - it should be inverted.