Skip to content

Conversation

davidmunechika
Copy link
Contributor

@davidmunechika davidmunechika commented Nov 18, 2021

User facing changelog

CYPRESS environment variable will be set to true in child processes where Cypress runs user code in node. Users can now detect that we're running in Cypress by looking for process.env.CYPRESS.

Additional details

Enable the ability to set different babel config when run within Cypress specifically without having to use CYPRESS_INTERNAL_ENV which is reserved for internal use.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@davidmunechika davidmunechika self-assigned this Nov 18, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 18, 2021

Thanks for taking the time to open a PR!

@davidmunechika davidmunechika force-pushed the issue-18805-cypress-env-var branch from e4bf694 to 104c815 Compare November 18, 2021 16:51
@cypress
Copy link

cypress bot commented Nov 18, 2021



Test summary

18690 0 202 0Flakiness 6


Run details

Project cypress
Status Passed
Commit 737909d
Started Nov 19, 2021 2:47 PM
Ended Nov 19, 2021 2:58 PM
Duration 11:16 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
settings_spec.js Flakiness
1 Settings > file preference panel > loads preferred editor, available editors and shows spinner
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code
2 ... > works with forceNetworkError
e2e/redirects_spec.js Flakiness
1 redirection > meta > binds to the new page after a timeout
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davidmunechika davidmunechika marked this pull request as ready for review November 19, 2021 14:44
@davidmunechika davidmunechika requested a review from a team as a code owner November 19, 2021 14:44
@davidmunechika davidmunechika requested review from a team, chrisbreiding and jennifer-shehane and removed request for a team November 19, 2021 14:44
@jennifer-shehane jennifer-shehane removed their request for review November 19, 2021 16:17
@jennifer-shehane jennifer-shehane merged commit de4fca3 into develop Nov 22, 2021
@jennifer-shehane jennifer-shehane deleted the issue-18805-cypress-env-var branch November 22, 2021 14:39
tgriesser added a commit that referenced this pull request Nov 28, 2021
* develop:
  test: node_modules installs for system-tests, other improvements (#18574)
  chore(deps): update dependency semantic-release to v17.2.3 [security] (#19022)
  chore: remove flaky ci jobs for main builds (#19071)
  chore(contributing): clarify PULL_REQUEST_TEMPLATE (#19068)
  fix: the shadow root container element is ignored when clicking an element in it. (#18908)
  'Fix' flaky redirect test (#19042)
  release 9.1.0 [skip ci]
  fix: Allow 'this' to be used in overridden commands (#18899)
  fix(react): link to rerender example (#19020)
  chore(deps): update dependency aws-sdk to v2.814.0 [security] (#18948)
  fix: test config overrides leak for .only execution (#18961)
  feat: Set CYPRESS=true as env var in child processes where Cypress runs user code in Node (#18981)
  fix: Restore broken gif (#18987)
  chore: release @cypress/vite-dev-server-v2.2.1
lmiller1990 pushed a commit that referenced this pull request Nov 29, 2021
tgriesser added a commit that referenced this pull request Nov 29, 2021
* 10.0-release:
  feat(graphql): ability to update/query for appData (#19082)
  fix system test
  fix failing tests due to merge
  resolve conflicts
  test: node_modules installs for system-tests, other improvements (#18574)
  update yarn.lock
  chore(deps): update dependency semantic-release to v17.2.3 [security] (#19022)
  chore: remove flaky ci jobs for main builds (#19071)
  chore(contributing): clarify PULL_REQUEST_TEMPLATE (#19068)
  fix: the shadow root container element is ignored when clicking an element in it. (#18908)
  'Fix' flaky redirect test (#19042)
  release 9.1.0 [skip ci]
  fix: Allow 'this' to be used in overridden commands (#18899)
  fix(react): link to rerender example (#19020)
  chore(deps): update dependency aws-sdk to v2.814.0 [security] (#18948)
  fix: test config overrides leak for .only execution (#18961)
  feat: Set CYPRESS=true as env var in child processes where Cypress runs user code in Node (#18981)
  fix: Restore broken gif (#18987)
  chore: release @cypress/vite-dev-server-v2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set CYPRESS=true as env var in child processes where Cypress runs user code in Node

3 participants