Skip to content

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Nov 22, 2021

Updated to run all tests through CircleCI and remove Appveyor configuration & supporting Appveyor scripts.

Appveyor
Ran for master, develop, release branch or branches matching /win*/. It ran:

  • yarn install
  • yarn build-prod
  • unit tests -- test-mocha
  • built binary & npm package; uploaded & crated post-install comment.

CircleCI
The current Windows workflows will run for develop or release branch. It runs:

  • yarn install
  • yarn build
  • lint tests
  • Unit Tests -- test-mocha, test-scripts & test-mocha-snapshot
  • Create Build Artifacts - builds binary & npm package. Will upload these & create post-install comment when develop or release branch.

Other Notes
A few changes were needed to the existing CircleCI scripts to support windows paths.

  • Globby was replaced with Glob due to multiple windows issues.
  • A new resource_size parameter was added to jobs utilized by the windows workflow to ensure the windows VM is started with a supported resource size. Adding new jobs to the windows workflow in the future will also require this change.
  • .gitattributes was added & ran git add --renormalize . to normalize line endings.

User facing changelog

n/a

How has the user experience changed?

n/a

PR Tasks

  • Have tests been added/updated?
  • [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@jennifer-shehane
Copy link
Member

@emilyrohrbough Why is this still triggering a run in Appveyor?

@emilyrohrbough
Copy link
Member Author

emilyrohrbough commented Nov 24, 2021

@jennifer-shehane It runs for all branches, we just filter the CI execution by branch in the appveyor.yml. It's failing here because it can't find the appveryor.yml since I deleted it in this PR. I'll need to update & likely remove the cypress project from Appveyor once this merged & will need to remove the appveyor status check.

EDIT - I updated the Appveyor configuration to remove the default MSBuild configuration when .appveyor is not present.

@pstakoun pstakoun requested review from flotwig and mjhenkes November 29, 2021 16:42
console.log('****************************')

const packages = await globby('packages/*/node_modules', {
const packages = glob.sync('packages/*/node_modules', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could keep this async with glob and use await just like globby. 🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i take it back, i see it's more involved than that.

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very very nice, thank you for cleaning up so much of the build/CI process while creating this PR.

I still want to do manual testing on Windows once this finishes building, but this looks almost perfect to me from a code standpoint.

## Webpack

Webpack-dev-server fulfills his reponsibilities by
Webpack-dev-server fulfills his responsibilities by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL webpack-dev-server is a boy

@flotwig
Copy link
Contributor

flotwig commented Nov 30, 2021

Manually tested the Windows build in open mode and it works great, but the code signing appears to be gone after this PR. I think CircleCI is most likely just missing the code signing environment variable:

cypress/appveyor.yml

Lines 35 to 38 in 2c9cb68

CSC_KEY_PASSWORD:
secure: GiXelhGGKXKUNW6T7ptKUw==
CSC_LINK:
secure: 9uSZwUYwcdZejLTpGpySd6t9JSL1Hw3iTvb4T2HZrx6iKd5DSR7AN6A7lS5ThTZ6g1JNSypSHRwDeC1Z5xkP8QEIjDqKjyNrqC19gCiSMrpdjjIR8Y8upIISrDBWjOiI

8.3.0:
image

This PR (no Digital Signatures tab):
image

flotwig
flotwig previously approved these changes Dec 2, 2021
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code signing appears to work now 👍
image

mjhenkes
mjhenkes previously approved these changes Dec 2, 2021
@elevatebart elevatebart dismissed stale reviews from mjhenkes and flotwig via 21712a5 December 2, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Windows Tests from Appveyor to CircleCI

5 participants