-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: Migrate Windows Tests from Appveyor to CircleCI #19037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@emilyrohrbough Why is this still triggering a run in Appveyor? |
@jennifer-shehane It runs for all branches, we just filter the CI execution by branch in the appveyor.yml. It's failing here because it can't find the appveryor.yml since I deleted it in this PR. I'll need to update & likely remove the cypress project from Appveyor once this merged & will need to remove the appveyor status check. EDIT - I updated the Appveyor configuration to remove the default MSBuild configuration when .appveyor is not present. |
console.log('****************************') | ||
|
||
const packages = await globby('packages/*/node_modules', { | ||
const packages = glob.sync('packages/*/node_modules', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could keep this async with glob and use await just like globby. 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i take it back, i see it's more involved than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very very nice, thank you for cleaning up so much of the build/CI process while creating this PR.
I still want to do manual testing on Windows once this finishes building, but this looks almost perfect to me from a code standpoint.
## Webpack | ||
|
||
Webpack-dev-server fulfills his reponsibilities by | ||
Webpack-dev-server fulfills his responsibilities by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL webpack-dev-server is a boy
Manually tested the Windows build in open mode and it works great, but the code signing appears to be gone after this PR. I think CircleCI is most likely just missing the code signing environment variable: Lines 35 to 38 in 2c9cb68
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to run all tests through CircleCI and remove Appveyor configuration & supporting Appveyor scripts.
Appveyor
Ran for master, develop, release branch or branches matching /win*/. It ran:
CircleCI
The current Windows workflows will run for develop or release branch. It runs:
Other Notes
A few changes were needed to the existing CircleCI scripts to support windows paths.
resource_size
parameter was added to jobs utilized by the windows workflow to ensure the windows VM is started with a supported resource size. Adding new jobs to the windows workflow in the future will also require this change.git add --renormalize .
to normalize line endings.User facing changelog
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?