Skip to content

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Dec 7, 2021

User facing changelog

Remove unused testing preferences

Additional details

useDarkSidebar and watchForSpecChange are unused/not implemented and won't be implemented by release so they are getting removed.

How has the user experience changed?

Lonely preference
Screen Shot 2021-12-07 at 5 16 04 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 7, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 7, 2021



Test summary

18147 0 202 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 8703986
Started Dec 7, 2021 11:38 PM
Ended Dec 7, 2021 11:50 PM
Duration 12:14 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 self-requested a review December 8, 2021 03:04
@lmiller1990 lmiller1990 merged commit e6cbee4 into 10.0-release Dec 8, 2021
@lmiller1990 lmiller1990 deleted the remove-unnecessary-preferences branch December 8, 2021 03:27
tgriesser added a commit that referenced this pull request Dec 9, 2021
* 10.0-release: (53 commits)
  refactor: makeLegacyContext -> getCtx (#19308)
  fix: various Nav Bar fixes (#19283)
  build: add patch package as a dev dependency for fe-shared
  chore: hoist is - fun with cached dependencies
  build: hoist is hard
  build: better hoisting strategy
  chore: remove unused testing preferences (#19301)
  fix: remove windows and mac workflow from branch
  fix: show script errors when spec file fails to process (#19298)
  revert: remove change about node version 17
  feat: open config file in user's editor (#19276)
  feat(unify): scale the AUT (#19297)
  build: remove testing of desktop-gui assets
  build: run window & mac CI in this branch
  build: more fixes
  build: remove toycode mdi from launchpad
  rename patch because of dev dep
  build: fix  merge issue in packages generation
  chore: update sass for windows compatibility
  fix: Do not crash when a ill formed URL request is proxied (#19274)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants