fix: close chrome when closing electron

[estrada9166]

• Closes Quitting Cypress does not also quit the running browser #18827

User facing changelog

Fixed an issue where Chromium-family browsers would stay open after closing cypress open.

Additional details

• If chrome is open, and electron is closed, the chrome process is not being killed
• This was broken before because process.on('exit') handlers have to be synchronous, and this was async

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

18733 • 0 • 202 • 0 • 3

---

Run details

Project	cypress
Status	Passed
Commit	9b2699b
Started	Dec 9, 2021 6:51 PM
Ended	Dec 9, 2021 7:03 PM
Duration	11:20 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/commands/net_stubbing_spec.ts		3
1	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

@estrada9166 does this close an issue?

Also, could you add/update a test? I think all this needs to be tested is to update the existing test here to expect it to be synchronous:

cypress/packages/server/test/unit/browsers/chrome_spec.js

Lines 293 to 309 in a64b72a

	it('calls cri client close on kill', function () {
	// need a reference here since the stub will be monkey-patched
	const {
	kill,
	} = this.launchedBrowser
	return chrome.open('chrome', 'http://', {}, this.automation)
	.then(() => {
	expect(this.launchedBrowser.kill).to.be.a('function')
	return this.launchedBrowser.kill()
	}).then(() => {
	expect(this.criClient.close).to.be.calledOnce
	expect(kill).to.be.calledOnce
	})
	})

[flotwig]

Awesome

[AtofStryker]

nice!