Windows build fix #19380
Closed
Windows build fix #19380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
elevatebart
suggested changes
Dec 15, 2021
|
|
||
| export async function graphqlCodegenWatch () { | ||
| const spawned = spawn('graphql-codegen', ['--watch', '--config', 'graphql-codegen.yml'], { | ||
| const spawned = spawn('bash.exe', ['graphql-codegen','--watch', '--config', 'graphql-codegen.yml'], { |
There was a problem hiding this comment.
is this working on macos?
| const dfd = pDefer() | ||
| const spawned = spawn( | ||
| devServer | ||
| `bash.exe ${devServer |
There was a problem hiding this comment.
this is unnecessary, one can simply add the .cmd at the end to get the windows version
|
I believe this PR is accomplishing the same goal. #19401 |
|
@elevatebart Thanks bart. Just wanted to surface in case it was useful. Feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?