Skip to content

Conversation

sainthkh
Copy link
Contributor

User facing changelog

N/A. It's just removing // @ts-nocheck comments and defining types to avoid type errors.

Additional details

  • Why was this change necessary? => To make pkg/driver files more type-safe.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => N/A

How has the user experience changed?

N/A

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 27, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review December 29, 2021 01:24
@sainthkh sainthkh requested a review from a team as a code owner December 29, 2021 01:24
@sainthkh sainthkh requested review from jennifer-shehane and removed request for a team December 29, 2021 01:24
@jennifer-shehane jennifer-shehane requested review from AtofStryker and tbiethman and removed request for jennifer-shehane January 3, 2022 18:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other TS newbies curious what this ! is doing: Non-null assertion operator

Copy link
Contributor

@tbiethman tbiethman Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding an explicit type for options if we are reading properties off of it. Or is this represented in the types already?

Edit: Based on your other changes, might need a TODO here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The past tense of cast is cast. My lint spellchecker doesn't flag 'casted' as an unknown word, though 🤷‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this answer, casted was used in Middle English and can be used when it's used for cast in programming context.

But I changed all casted to cast anyway.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I get this done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finda841 In this PR, there's nothing you can do because I've finished all the suggested changes. If you want to help develop Cypress, you can find ready-for-work issues here.

tbiethman
tbiethman previously approved these changes Jan 5, 2022
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a few questions and suggestions but otherwise looks like some solid progress!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: change `any` to Loggable
// TODO: change the options type from `any` to `Loggable`.

@BlueWinds
Copy link
Contributor

I'm wondering if for future PRs like this, it might be good to target them at the 10.0-release branch rather than develop. I know the component testing team has added some additional types to cypress, and as we approach releasing that branch, anything we can do to lessen the burden of merging develop -> 10.0 will make their lives easier.

Don't need to rebase / retarget these changes, just something to think about for future PRs.

tbiethman
tbiethman previously approved these changes Jan 6, 2022
AtofStryker
AtofStryker previously approved these changes Jan 6, 2022
@sainthkh sainthkh dismissed stale reviews from AtofStryker and tbiethman via 0043826 January 9, 2022 23:44
@sainthkh sainthkh force-pushed the remove-driver-no-check-part-2 branch from 152e6df to 0043826 Compare January 9, 2022 23:44
@AtofStryker AtofStryker self-requested a review January 10, 2022 18:23
@tbiethman tbiethman merged commit ea531b7 into cypress-io:develop Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants