Skip to content

Conversation

tgriesser
Copy link
Member

@tgriesser tgriesser commented Feb 10, 2022

We are seeing flake in CI around the e2e_cookies_spec

https://app.circleci.com/pipelines/github/cypress-io/cypress/31590/workflows/9fdd5ccd-d68e-4b77-8388-404cc96d2948/jobs/1234911/tests#failed-test-0

Tracked it down to most likely being due to a change in #19837 which changed null -> false on some values which might have had some unintended consequences. (Not 100% sure on this though, was just the first thing I tried with open mode locally and it seemed to make a difference)

Also fixed up a pesky yarn install bug that comes up occasionally where our patched jQuery types are broken by the double uncommenting, requiring blowing away node_modules

@tgriesser tgriesser requested a review from a team as a code owner February 10, 2022 05:00
@tgriesser tgriesser requested review from jennifer-shehane and removed request for a team February 10, 2022 05:00
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 10, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 10, 2022



Test summary

19185 0 218 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 9866e2f
Started Feb 10, 2022 4:57 AM
Ended Feb 10, 2022 5:08 AM
Duration 11:35 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/xhr_spec.js Flakiness
1 ... > can alias a route without stubbing it

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser
Copy link
Member Author

This actually doesn't seem to be the issue. Needs more investigation

@tgriesser tgriesser closed this Feb 10, 2022
@tgriesser tgriesser deleted the tgriesser/fix/flake-in-e2e_cookies_spec branch February 10, 2022 14:48
@jennifer-shehane jennifer-shehane removed their request for review February 10, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant