fix: changes from #19837 causing flake in e2e_cookies_spec #20139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing flake in CI around the
e2e_cookies_spec
https://app.circleci.com/pipelines/github/cypress-io/cypress/31590/workflows/9fdd5ccd-d68e-4b77-8388-404cc96d2948/jobs/1234911/tests#failed-test-0
Tracked it down to most likely being due to a change in #19837 which changed
null
->false
on some values which might have had some unintended consequences. (Not 100% sure on this though, was just the first thing I tried with open mode locally and it seemed to make a difference)Also fixed up a pesky yarn install bug that comes up occasionally where our patched jQuery types are broken by the double uncommenting, requiring blowing away
node_modules