Skip to content

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review March 12, 2024 20:02
@cacieprins cacieprins requested a review from mschile March 12, 2024 20:10
Co-authored-by: Matt Schile <[email protected]>
Copy link

cypress bot commented Mar 12, 2024

1 flaky test on run #54496 ↗︎

0 230 4 0 Flakiness 1

Details:

changelog entries for #28986
Project: cypress Commit: 856b3044ca
Status: Passed Duration: 11:39 💡
Started: Mar 12, 2024 9:03 PM Ended: Mar 12, 2024 9:15 PM
Flakiness  cypress/e2e/project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
... > can skip setup CT testing for an E2E project Test Replay Screenshots

Review all test suite changes for PR #29123 ↗︎

@cacieprins cacieprins merged commit 5503dd6 into develop Mar 12, 2024
@cacieprins cacieprins deleted the chore/release_13_7_0 branch March 12, 2024 21:13
@MikeMcC399

This comment was marked as resolved.

"devDependencies": {
"cross-env": "6.0.3",
"cypress-example-kitchensink": "2.0.2",
"cypress-example-kitchensink": "2.0.3",

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**Performance:**

- Fixed a performance regression from [`13.6.4`](https://docs.cypress.io/guides/references/changelog#13-6-4) where unhandled service worker requests may not correlate correctly. Fixes [#28868](https://github.com/cypress-io/cypress/issues/28868).
- Fixed a performance regression from [`13.6.3`](https://docs.cypress.io/guides/references/changelog#13-6-3) where unhandled service worker requests may not correlate correctly. Fixes [#28868](https://github.com/cypress-io/cypress/issues/28868).
Copy link

@gabrielbahniuk gabrielbahniuk Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mschile regarding #29123 (comment), i'm confused, wasn't the performance regression reintroduced in 13.6.4 (and introduced the first time in 13.6.1)? From what I've tested, 13.6.1 super slow, then 13.6.3 works fine and from 13.6.4 on it doubles the time for network responses in my tests (slow again).

13.6.0 ✅
13.6.1 ❌
13.6.2 ❌
13.6.3 ✅
13.6.4 ❌
13.6.5 ❌
13.6.6 ❌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielbahniuk, not that we are aware of. Can you try the pre-release binary (or wait until 13.7.0 is released) to see if it resolves your performance issue:

npm install https://cdn.cypress.io/beta/npm/13.7.0/linux-x64/develop-f8f7e71907870a50784a1a8547940902362b58e2/cypress.tgz

If your performance issue is not resolved, could you please open a new issue with a reproducible example so we can investigate.

Copy link

@gabrielbahniuk gabrielbahniuk Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mschile sure, will do and reply here, but it's weird bc I tested multiple times and everything points to a fix in 13.6.3 (that's the version I'm using right now, as 13.6.4 also didn't work).

@cacieprins cacieprins restored the chore/release_13_7_0 branch March 13, 2024 15:06
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 13, 2024

Released in 13.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 13, 2024
@mschile mschile deleted the chore/release_13_7_0 branch September 23, 2025 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants