breaking: Move getSelector and reset to private methods on ElementSelector API #32098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods on ElementSelector API BREAKING: Move getSelector, getSelectorPriority, and reset to private methods on ElementSelector API
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
private-apis-on-element-selector
|
| Run status |
|
| Run duration | 11m 16s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
687
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
37.62%
|
|
|---|---|
|
Untested elements
|
131
|
|
Tested elements
|
79
|
Accessibility
97.38%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
1 moderate
1 minor
|
|
Failed elements
|
62
|
jennifer-shehane
changed the title
jennifer-shehane
added
the
type: breaking change
estrada9166
approved these changes
Jul 29, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: https://github.com/cypress-io/cypress-services/pull/11234
Additional details
We don't intend to have the
getSelectorAPI public anymore with the functionality moving and not needing to be public. We can add it back if it's a highly requested feature.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation? Rewrite to make its use more understandable + remove getSelector cypress-documentation#6235type definitions?