-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(deps): update dependency vite to 6.3.6 [security] #32457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
103e316
to
a96f166
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
const raiseErrorFn = throwFormErrorText(errors.missingXvfb) | ||
|
||
await raiseErrorFn(e) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Async/Await Error Handling Regression
The async/await
conversion changed error handling in xvfb.ts
and spawn.ts
. Calls to await raiseErrorFn(...)
now lead to unreachable code because these functions always throw. This also alters the error flow in xvfb.ts
's start
method, causing some errors (e.g., known: true
without nonZeroExitCode: true
) to be re-thrown instead of being caught by the missingXvfb
handler.
Additional Locations (1)
cypress
|
Project |
cypress
|
Branch Review |
renovate/npm-vite-vulnerability
|
Run status |
|
Run duration | 38m 45s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
1
|
|
2
|
|
976
|
|
0
|
|
16446
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
44.86%
|
|
---|---|
|
188
|
|
157
|
Accessibility
97.71%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
Tests for review
cypress/e2e/e2e/origin/cookie_login.cy.ts • 1 failed test • 5x-driver-firefox
Test | Artifacts | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
cy.origin - cookie login > general behavior > handles browser-sent cookies being overridden by server-kept cookies |
|
Test | Artifacts | |||||||
---|---|---|---|---|---|---|---|---|
... > stops waiting when an xhr request is canceled |
|
Test | Artifacts | |
---|---|---|
... > runs generated spec |
Test Replay
Screenshots
|
This PR contains the following updates:
6.3.5
->6.3.6
GitHub Vulnerability Alerts
CVE-2025-46565
Summary
The contents of files in the project
root
that are denied by a file matching pattern can be returned to the browser.Impact
Only apps explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.
Only files that are under project
root
and are denied by a file matching pattern can be bypassed..env
,.env.*
,*.{crt,pem}
,**/.env
**/.git/**
,.git/**
,.git/**/*
Details
server.fs.deny
can contain patterns matching against files (by default it includes.env
,.env.*
,*.{crt,pem}
as such patterns).These patterns were able to bypass for files under
root
by using a combination of slash and dot (/.
).PoC
CVE-2025-58752
Summary
Any HTML files on the machine were served regardless of the
server.fs
settings.Impact
Only apps that match the following conditions are affected:
appType: 'spa'
(default) orappType: 'mpa'
is usedThis vulnerability also affects the preview server. The preview server allowed HTML files not under the output directory to be served.
Details
The serveStaticMiddleware function is in charge of serving static files from the server. It returns the viteServeStaticMiddleware function which runs the needed tests and serves the page. The viteServeStaticMiddleware function checks if the extension of the requested file is ".html". If so, it doesn't serve the page. Instead, the server will go on to the next middlewares, in this case htmlFallbackMiddleware, and then to indexHtmlMiddleware. These middlewares don't perform any test against allow or deny rules, and they don't make sure that the accessed file is in the root directory of the server. They just find the file and send back its contents to the client.
PoC
Execute the following shell commands:
Then, in a different shell, run the following command:
curl -v --path-as-is 'http://localhost:5173/../../../../../../../../../../../tmp/secret.html'
The contents of /tmp/secret.html will be returned.
This will also work for HTML files that are in the root directory of the project, but are in the deny list (or not in the allow list). Test that by stopping the running server (CTRL+C), and running the following commands in the server's shell:
Then, in a different shell, run the following command:
curl -v --path-as-is 'http://localhost:5173/secret_files/secret.txt'
You will receive a 403 HTTP Response, because everything in the secret_files directory is denied.
Now in the same shell run the following command:
curl -v --path-as-is 'http://localhost:5173/secret_files/secret.html'
You will receive the contents of secret_files/secret.html.
CVE-2025-58751
Summary
Files starting with the same name with the public directory were served bypassing the
server.fs
settings.Impact
Only apps that match the following conditions are affected:
server.host
config option)Details
The servePublicMiddleware function is in charge of serving public files from the server. It returns the viteServePublicMiddleware function which runs the needed tests and serves the page. The viteServePublicMiddleware function checks if the publicFiles variable is defined, and then uses it to determine if the requested page is public. In the case that the publicFiles is undefined, the code will treat the requested page as a public page, and go on with the serving function. publicFiles may be undefined if there is a symbolic link anywhere inside the public directory. In that case, every requested page will be passed to the public serving function. The serving function is based on the sirv library. Vite patches the library to add the possibility to test loading access to pages, but when the public page middleware disables this functionality since public pages are meant to be available always, regardless of whether they are in the allow or deny list.
In the case of public pages, the serving function is provided with the path to the public directory as a root directory. The code of the sirv library uses the join function to get the full path to the requested file. For example, if the public directory is "/www/public", and the requested file is "myfile", the code will join them to the string "/www/public/myfile". The code will then pass this string to the normalize function. Afterwards, the code will use the string's startsWith function to determine whether the created path is within the given directory or not. Only if it is, it will be served.
Since sirv trims the trailing slash of the public directory, the string's startsWith function may return true even if the created path is not within the public directory. For example, if the server's root is at "/www", and the public directory is at "/www/p", if the created path will be "/www/private.txt", the startsWith function will still return true, because the string "/www/private.txt" starts with "/www/p". To achieve this, the attacker will use ".." to ask for the file "../private.txt". The code will then join it to the "/www/p" string, and will receive "/www/p/../private.txt". Then, the normalize function will return "/www/private.txt", which will then be passed to the startsWith function, which will return true, and the processing of the page will continue without checking the deny list (since this is the public directory middleware which doesn't check that).
PoC
Execute the following shell commands:
Then, in a different shell, run the following command:
curl -v --path-as-is 'http://localhost:5173/private.txt'
You will receive a 403 HTTP Response, because private.txt is denied.
Now in the same shell run the following command:
curl -v --path-as-is 'http://localhost:5173/../private.txt'
You will receive the contents of private.txt.
Related links
Release Notes
vitejs/vite (vite)
v6.3.6
Compare Source
Please refer to CHANGELOG.md for details.
Configuration
📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.