Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2025

Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vite-5 (source) ^5.4.19 -> ^7.1.5 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-58752

Summary

Any HTML files on the machine were served regardless of the server.fs settings.

Impact

Only apps that match the following conditions are affected:

  • explicitly exposes the Vite dev server to the network (using --host or server.host config option)
  • appType: 'spa' (default) or appType: 'mpa' is used

This vulnerability also affects the preview server. The preview server allowed HTML files not under the output directory to be served.

Details

The serveStaticMiddleware function is in charge of serving static files from the server. It returns the viteServeStaticMiddleware function which runs the needed tests and serves the page. The viteServeStaticMiddleware function checks if the extension of the requested file is ".html". If so, it doesn't serve the page. Instead, the server will go on to the next middlewares, in this case htmlFallbackMiddleware, and then to indexHtmlMiddleware. These middlewares don't perform any test against allow or deny rules, and they don't make sure that the accessed file is in the root directory of the server. They just find the file and send back its contents to the client.

PoC

Execute the following shell commands:

npm  create  vite@latest
cd vite-project/
echo  "secret" > /tmp/secret.html
npm install
npm run dev

Then, in a different shell, run the following command:

curl -v --path-as-is 'http://localhost:5173/../../../../../../../../../../../tmp/secret.html'

The contents of /tmp/secret.html will be returned.

This will also work for HTML files that are in the root directory of the project, but are in the deny list (or not in the allow list). Test that by stopping the running server (CTRL+C), and running the following commands in the server's shell:

echo  'import path from "node:path"; import { defineConfig } from "vite"; export default defineConfig({server: {fs: {deny: [path.resolve(__dirname, "secret_files/*")]}}})'  >  [vite.config.js](http://vite.config.js)
mkdir secret_files
echo "secret txt" > secret_files/secret.txt
echo "secret html" > secret_files/secret.html
npm run dev

Then, in a different shell, run the following command:

curl -v --path-as-is 'http://localhost:5173/secret_files/secret.txt'

You will receive a 403 HTTP Response,  because everything in the secret_files directory is denied.

Now in the same shell run the following command:

curl -v --path-as-is 'http://localhost:5173/secret_files/secret.html'

You will receive the contents of secret_files/secret.html.

CVE-2025-58751

Summary

Files starting with the same name with the public directory were served bypassing the server.fs settings.

Impact

Only apps that match the following conditions are affected:

Details

The servePublicMiddleware function is in charge of serving public files from the server. It returns the viteServePublicMiddleware function which runs the needed tests and serves the page. The viteServePublicMiddleware function checks if the publicFiles variable is defined, and then uses it to determine if the requested page is public. In the case that the publicFiles is undefined, the code will treat the requested page as a public page, and go on with the serving function. publicFiles may be undefined if there is a symbolic link anywhere inside the public directory. In that case, every requested page will be passed to the public serving function. The serving function is based on the sirv library. Vite patches the library to add the possibility to test loading access to pages, but when the public page middleware disables this functionality since public pages are meant to be available always, regardless of whether they are in the allow or deny list.

In the case of public pages, the serving function is provided with the path to the public directory as a root directory. The code of the sirv library uses the join function to get the full path to the requested file. For example, if the public directory is "/www/public", and the requested file is "myfile", the code will join them to the string "/www/public/myfile". The code will then pass this string to the normalize function. Afterwards, the code will use the string's startsWith function to determine whether the created path is within the given directory or not. Only if it is, it will be served.

Since sirv trims the trailing slash of the public directory, the string's startsWith function may return true even if the created path is not within the public directory. For example, if the server's root is at "/www", and the public directory is at "/www/p", if the created path will be "/www/private.txt", the startsWith function will still return true, because the string "/www/private.txt" starts with  "/www/p". To achieve this, the attacker will use ".." to ask for the file "../private.txt". The code will then join it to the "/www/p" string, and will receive "/www/p/../private.txt". Then, the normalize function will return "/www/private.txt", which will then be passed to the startsWith function, which will return true, and the processing of the page will continue without checking the deny list (since this is the public directory middleware which doesn't check that).

PoC

Execute the following shell commands:

npm  create  vite@latest
cd vite-project/
mkdir p
cd p
ln -s a b
cd ..
echo  'import path from "node:path"; import { defineConfig } from "vite"; export default defineConfig({publicDir: path.resolve(__dirname, "p/"), server: {fs: {deny: [path.resolve(__dirname, "private.txt")]}}})' > vite.config.js
echo  "secret" > private.txt
npm install
npm run dev

Then, in a different shell, run the following command:

curl -v --path-as-is 'http://localhost:5173/private.txt'

You will receive a 403 HTTP Response,  because private.txt is denied.

Now in the same shell run the following command:

curl -v --path-as-is 'http://localhost:5173/../private.txt'

You will receive the contents of private.txt.

Related links


Release Notes

vitejs/vite (vite-5)

v7.1.5

Compare Source

Bug Fixes

v7.1.4

Compare Source

Bug Fixes
Miscellaneous Chores
Code Refactoring

v7.1.3

Compare Source

Features
Bug Fixes
Performance Improvements
Miscellaneous Chores
Code Refactoring
Tests

v7.1.2

Compare Source

Bug Fixes
Miscellaneous Chores

v7.1.1

Compare Source

Bug Fixes
Miscellaneous Chores

v7.1.0

Compare Source

Features
  • support files with more than 1000 lines by generateCodeFrame (#​20508) (e7d0b2a)
Bug Fixes
Tests

v7.0.7

Compare Source

Please refer to CHANGELOG.md for details.

v7.0.6

Compare Source

Bug Fixes
Miscellaneous Chores
Code Refactoring

v7.0.5

Compare Source

Bug Fixes
Miscellaneous Chores
Code Refactoring

v7.0.4

Compare Source

Bug Fixes
  • allow resolving bare specifiers to relative paths for entries (#​20379) (324669c)
Build System

v7.0.3

Compare Source

Bug Fixes
Miscellaneous Chores
Code Refactoring
  • minor changes to reduce diff between normal Vite and rolldown-vite (#​20354) (2e8050e)

v7.0.2

Compare Source

Bug Fixes

v7.0.1

Compare Source

Bug Fixes
Miscellaneous Chores

v7.0.0

Compare Source

v6.3.6

Compare Source

Please refer to CHANGELOG.md for details.

v6.3.5

Compare Source

v6.3.4

Compare Source

Bug Fixes
  • check static serve file inside sirv (#​19965) (c22c43d)
  • optimizer: return plain object when using require to import externals in optimized dependencies (#​19940) (efc5eab)
Code Refactoring

v6.3.3

Compare Source

v6.3.2

Compare Source

Features
Bug Fixes

v6.3.1

Compare Source

Bug Fixes

v6.3.0

Compare Source

v6.2.7

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.6

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.5

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.4

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.3

Compare Source

Please refer to CHANGELOG.md for details.

v6.2.2

Compare Source

v6.2.1

Compare Source

Features
  • add *?url&no-inline type and warning for .json?inline / .json?no-inline (#​19566) (c0d3667)
Bug Fixes
  • css: stabilize css module hashes with lightningcss in dev mode (#​19481) (92125b4)
  • deps: update all non-major dependencies (#​19555) (f612e0f)
  • reporter: fix incorrect bundle size calculation with non-ASCII characters (#​19561) (437c0ed)
  • sourcemap: combine sourcemaps with multiple sources without matched source (#​18971) (e3f6ae1)
  • ssr: named export should overwrite export all (#​19534) (2fd2fc1)
Performance Improvements
Miscellaneous Chores
Code Refactoring
Tests

v6.2.0

Compare Source

Bug Fixes
Miscellaneous Chores

v6.1.6

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.5

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.4

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.3

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.2

Compare Source

Please refer to CHANGELOG.md for details.

v6.1.1

Compare Source

Features
Bug Fixes
Miscellaneous Chores
Code Refactoring

v6.1.0

Compare Source

Features
Bug Fixes
Miscellaneous Chores
Code Refactoring

v6.0.15

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.14

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.13

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.12

Compare Source

Please refer to CHANGELOG.md for details.

v6.0.11

Compare Source

Features

Configuration

📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@cypress-app-bot
Copy link
Collaborator

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

cursor[bot]

This comment was marked as outdated.

@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from c0bfe1c to 2d90783 Compare September 10, 2025 16:43
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 10, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 2d90783 to 25be1ec Compare September 10, 2025 17:06
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 10, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 25be1ec to b324abf Compare September 11, 2025 19:11
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 11, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from b324abf to c24f87b Compare September 11, 2025 20:29
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 11, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from c24f87b to 8b2058b Compare September 12, 2025 18:52
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 12, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch 2 times, most recently from 0e66d70 to 57e98ab Compare September 12, 2025 19:51
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 12, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 57e98ab to 8f8eae2 Compare September 12, 2025 23:47
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 12, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 8f8eae2 to 21564df Compare September 12, 2025 23:51
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 12, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 21564df to 27af983 Compare September 15, 2025 14:21
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 27af983 to 042c180 Compare September 15, 2025 14:25
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 042c180 to 28bdbd9 Compare September 15, 2025 17:03
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 28bdbd9 to b50a3a6 Compare September 15, 2025 17:08
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from b50a3a6 to df3f228 Compare September 15, 2025 18:22
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 15, 2025
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 76ba573 to 437e088 Compare September 15, 2025 19:24
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 437e088 to e45b9db Compare September 15, 2025 19:33
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from e45b9db to ea58f8d Compare September 15, 2025 19:37
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 15, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from ea58f8d to 599fe07 Compare September 16, 2025 14:04
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 16, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 599fe07 to d2617a3 Compare September 16, 2025 14:10
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from d2617a3 to 29edf0b Compare September 16, 2025 15:00
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 16, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 29edf0b to 505e8a6 Compare September 16, 2025 15:15
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to ^5.4.20 [security] Sep 16, 2025
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 505e8a6 to 0b3e4b1 Compare September 16, 2025 15:28
@renovate renovate bot force-pushed the renovate/npm-vite-5-vulnerability branch from 0b3e4b1 to f688a7f Compare September 16, 2025 15:34
@renovate renovate bot changed the title chore(deps): update dependency vite-5 to ^5.4.20 [security] chore(deps): update dependency vite-5 to v7 [security] Sep 16, 2025
Copy link
Contributor Author

renovate bot commented Sep 16, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jennifer-shehane jennifer-shehane self-assigned this Sep 16, 2025
Copy link

cypress bot commented Sep 16, 2025

cypress    Run #65553

Run Properties:  status check passed Passed #65553  •  git commit d12be0bb2e: Merge branch 'renovate/npm-vite-5-vulnerability' of https://github.com/cypress-i...
Project cypress
Branch Review renovate/npm-vite-5-vulnerability
Run status status check passed Passed #65553
Run duration 19m 12s
Commit git commit d12be0bb2e: Merge branch 'renovate/npm-vite-5-vulnerability' of https://github.com/cypress-i...
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 10
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26662
View all changes introduced in this branch ↗︎
UI Coverage  45.11%
  Untested elements 186  
  Tested elements 157  
Accessibility  97.71%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 110  

@jennifer-shehane jennifer-shehane changed the title chore(deps): update dependency vite-5 to v7 [security] chore(deps): update dependency vite-5 to v5.4.20 [security] Sep 16, 2025
@jennifer-shehane jennifer-shehane merged commit 0d7e4b2 into develop Sep 16, 2025
90 of 92 checks passed
@jennifer-shehane jennifer-shehane deleted the renovate/npm-vite-5-vulnerability branch September 16, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants