-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: (cy.prompt) handle when the prompt is executed by in CT or when the experiment is not enabled #32470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryanthemanuel
merged 11 commits into
feat/cy-prompt
from
ryanm/fix/handle-experimental-config-better
Sep 16, 2025
Merged
fix: (cy.prompt) handle when the prompt is executed by in CT or when the experiment is not enabled #32470
ryanthemanuel
merged 11 commits into
feat/cy-prompt
from
ryanm/fix/handle-experimental-config-better
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the experiment is not enabled
We can probably remove some dead code on the services side at some point with this change. |
ryanthemanuel
commented
Sep 11, 2025
ryanthemanuel
commented
Sep 11, 2025
cypress
|
Project |
cypress
|
Branch Review |
ryanm/fix/handle-experimental-config-better
|
Run status |
|
Run duration | 20m 06s |
Commit |
|
Committer | Ryan Manuel |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
9
|
|
1102
|
|
4
|
|
26686
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
44.99%
|
|
---|---|
|
187
|
|
157
|
Accessibility
97.9%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
101
|
estrada9166
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Handle a few scenarios with the experiment better.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?