Type annotation pyi file and tests #1964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `FusedType` for the PEP484's stub file
* run mypy against test modules tagged with `mypy`
* Add `mypy` as a tag to the `pure_py3.py` test module. * Add type hint for MyStruct2 in pure_py3 test, because MyStruct2 is of type `cython.typedef` instead of `cython.StructType`, so one needs to explicitly provide its type.
|
Thanks. Since this is not complete and ready for merging yet, I've created an updated branch at #1965 for further improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Shadow.pyifrom python/typeshed#1554 to this repo and addAdd a test using
mypyto test the stub file used if the tagmypyis added.Therefore add
mypyto thetest-requirements.txt.Add the
mypytag topure_py3and an explicit type annotation forStruct2, becausemypydoes not automatically infer the type when thetypedeffunction is called.