Add support for scheduling jobs to run in the future #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaneb
reviewed
Nov 4, 2021
README.md
Outdated
| Job.objects.create(name='scheduled_job', run_after=timezone.now() + timedelta(minutes=10)) | ||
| ``` | ||
|
|
||
| Of course, the job will only be run if your `python manage.py worker` process is running at the time when the job is scheduled to run. Otherwise, it will run the next time you start your worker process after that time has passed. |
There was a problem hiding this comment.
is it worth noting that this isn't exact? say if you're queue has a large backlog it may be sometime before the worker can pick it up
There was a problem hiding this comment.
Have added a note on that. A large backlog shouldn't be so much of an issue, because jobs are picked up in order of creation - so scheduled jobs were probably created a long time ago and so will be picked up before any other jobs that have been created more recently. However if a job is currently being processed then of course your scheduled job will only run after it's finished.
jordaneb
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new (nullable)
run_afterfield to theJobmodel, which is aDateTimeField. If this field is populated, the job worker will ignore any jobs for whichrun_afteris in the future. This allows jobs to be scheduled to run later.