Regression in golangci-lint

[howardjohn]

We recently update golangci-lint and it broke gci, forcing us to disable it.

To reproduce:

istio/istio@3a245f8

$ golangci-lint run --fix -c ./common/config/.golangci-format.yml istioctl/pkg/util/proto/messageslice.go
istioctl/pkg/util/proto/messageslice.go:21:1: Expected '\t', Found '\n' at istioctl/pkg/util/proto/messageslice.go[line 21,col 1] (gci)

^

Can also run in our docker build:

./common/scripts/run.sh golangci-lint run --fix -c ./common/config/.golangci-format.yml istioctl/pkg/util/proto/messageslice.go

[daixiang0]

@howardjohn thanks for the report! Now, which version of golangci-lint do you use? I will investigate that version first.

[ivila]

@howardjohn thanks for the report! Now, which version of golangci-lint do you use? I will investigate that version first.

reproduce at golangci-lint 1.46.2

[daixiang0]

golangci/golangci-lint#2892 I think need to wait next fix version.

[daixiang0]

@howardjohn @ivila please wait for the next release, 1.46.2 is released on May 17, but the fix PR is merged on May 31.