(Bug) Updated definition loader to evaluate children inputs #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Updated the way of getting children of a JObject in order to evaluate expressions for inputs that have child elements.
Describe your implementation or design
Used the select token method in order to select the children then evaluate the type of the token before adding to the stack of JObjects.
Tests
Created a new step, DynamicDataStep that I have added into stored-dynamic-definition.json with a complex object in Inputs.
Breaking change
No, this is an added functionality on top. It is a bug fix because children items were not evaluated.
Additional context
We discovered the issue when working for a dynamic workflow solution for one of our clients.