GH-1609 : Fix for MongoDB Atlas conn strings (#1698)

ewassef · pigletfly · daixiang0 · web-flow · commit 785ed60ef4cc · 2022-05-13T16:13:13.000-07:00
* Update readme of bindings (#1690) Signed-off-by: pigletfly <wangbing.adam@gmail.com> Co-authored-by: Looong Dai <long.dai@intel.com> Signed-off-by: Eddie <eddie@wassef.com> * Fixing includedHeaders problem with spaces (#1610) Signed-off-by: Ben Kotvis <kotvisbj@gmail.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Co-authored-by: Looong Dai <long.dai@intel.com> Signed-off-by: Eddie <eddie@wassef.com> * Simplify vault token read (#1560) * Simplify vault token get Signed-off-by: zhangchao <zchao9100@gmail.com> * fix lint Signed-off-by: zhangchao <zchao9100@gmail.com> * update tests Signed-off-by: zhangchao <zchao9100@gmail.com> Co-authored-by: Looong Dai <long.dai@intel.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: Eddie <eddie@wassef.com> * GH-1609 : Fix for MongoDB Atlas conn strings Added recommended fix in the issue Signed-off-by: Eddie <eddie@wassef.com> * updating the comment based on PR feedback Signed-off-by: Eddie <eddie@wassef.com> * Initial Certification test for eventhubs binding [incomplete] (#1670) * certification test for eventhubs binding Signed-off-by: tanvigour <tanvi.gour@gmail.com> * modified go.mod and go.sum Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Add connection string testing Signed-off-by: tanvigour <tanvi.gour@gmail.com> * iothub testing Signed-off-by: tanvigour <tanvi.gour@gmail.com> * address feedback and run test Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Install Azure CLI IOT hub extension Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> * make modtidy-all Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> * covering all eventhubs test cases Signed-off-by: tanvigour <tanvi.gour@gmail.com> * dependency changes after go modtidy-all Signed-off-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Looong Dai <long.dai@intel.com> Signed-off-by: Eddie <eddie@wassef.com> * Use revive instead of golint (#1685) Signed-off-by: pigletfly <wangbing.adam@gmail.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: Eddie <eddie@wassef.com> * Updated to Go 1.18 (#1697) * Updated to Go 1.18 Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> * Added go.work file With Go 1.18, this allows gopls (the Go language server used for example in VS Code) to work inside test apps too. See: https://go.dev/doc/tutorial/workspaces Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Removed go.work Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * 💄 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Signed-off-by: Eddie <eddie@wassef.com> * Add metadata property to configure Batching in Pulsar (#1707) * Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <saberwang@hotmail.com> * sort field Signed-off-by: saberwang <saberwang@hotmail.com> * [pubsub]fix unit test bug Signed-off-by: saberwang <saberwang@hotmail.com> * remove unrelated changes Signed-off-by: saberwang <saberwang@hotmail.com> * Delete hard coded Metadata Signed-off-by: saberwang <saberwang@hotmail.com> * remove .history Signed-off-by: saberwang <saberwang@hotmail.com> * restore .gitignore Signed-off-by: saberwang <saberwang@hotmail.com> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <saberwang@hotmail.com> * fix code format Signed-off-by: saberwang <saberwang@hotmail.com> * formatting code Signed-off-by: saberwang <saberwang@hotmail.com> Co-authored-by: Looong Dai <long.dai@intel.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Signed-off-by: Eddie <eddie@wassef.com> * Fix 4529: Ignore Subscribe/Get wrong redis configuration type keys. (#1693) * fix: 4529 Signed-off-by: LaurenceLiZhixin <382673304@qq.com> * Fix: add test does not throw error for wrong type during get all test case of redis configuration Signed-off-by: LaurenceLiZhixin <382673304@qq.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Ian Luo <ian.luo@gmail.com> Signed-off-by: Eddie <eddie@wassef.com> * Signed-off-by: Eddie Wassef <eddie@wassef.com> Fixing leading newline in linter error Signed-off-by: Eddie <eddie@wassef.com> * Implment a secret store based on Huawei CSMS (#1710) Signed-off-by: Chen Cong <chock-cong.chen@outlook.com> Co-authored-by: Chen Cong <chock-cong.chen@outlook.com> Signed-off-by: Eddie <eddie@wassef.com> * Add yet another missing secret to eventhub binding cert test (#1713) Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Signed-off-by: Eddie <eddie@wassef.com> * Support custom queueEndpoint in Azure Storage Queues (#1692) * Support custom queueEndpoint in Azure Storage Queues Signed-off-by: Janusz Dziurzynski <janusz@corechain.tech> * run gofmt Signed-off-by: Janusz Dziurzynski <janusz@corechain.tech> * Add "Url" to JSON field name for clarity Suggested by @msfussell in dapr/docs#2424 Signed-off-by: Janusz Dziurzynski <janusz@corechain.tech> Signed-off-by: Eddie <eddie@wassef.com> * Refactory kafka binding to reuse the kafka common code extracting from kafka pubsub component (#1696) * refactory kafka pubsub code to extract common kafka code for reuse Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * fix lint;add unit test for subscribeAdapter Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * move topics filed from internal kafak struct to pubsub kafka struct, since in input binding the topics will confiured in metadata Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * reuse internal kafka code for bindings Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * add redis standalone_test back which is delete by mistaken Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * small code improvement to trigger test Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * add license headers Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * try to set disbaleTls to true to verify the kafka connection fail Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * don't enable consum retry in kafka binding component;if authenticaion is disabled, need not set TLSDisable at the same time; Signed-off-by: Sky Ao <aoxiaojian@gmail.com> * fix lint Signed-off-by: Sky Ao <aoxiaojian@gmail.com> Co-authored-by: Loong Dai <long.dai@intel.com> Signed-off-by: Eddie <eddie@wassef.com> * Add topic metadata for mqtt input binding and support user defined topic for mqtt output binding (#1674) * feat(bindings/mqtt): add data incoming topic to metadata Signed-off-by: lotuc <lotu.c@outlook.com> * feat(bindings/mqtt): support user defined topic on create action Signed-off-by: lotuc <lotu.c@outlook.com> * chore(bindings/mqtt): add integration test and topic response check test Signed-off-by: lotuc <lotu.c@outlook.com> * fix(bindings/mqtt): ignore misspell linting error for word mosquitto Signed-off-by: lotuc <lotu.c@outlook.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: Eddie <eddie@wassef.com> * Expire -> ExpiryInSeconds (#1721) Signed-off-by: seeflood <349895584@qq.com> Signed-off-by: Eddie <eddie@wassef.com> * running gofmt -s -w state/mongodb/mongodb.go Signed-off-by: Eddie <eddie@wassef.com> * Update mongodb.go Co-authored-by: Wang Bing <wangbing.adam@gmail.com> Co-authored-by: Looong Dai <long.dai@intel.com> Co-authored-by: Ben Kotvis <kotvisbj@gmail.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Co-authored-by: Taction <zchao9100@gmail.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: saber-wang <45062099+saber-wang@users.noreply.github.com> Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com> Co-authored-by: Ian Luo <ian.luo@gmail.com> Co-authored-by: Chock Chen <46557936+ChenCong0207@users.noreply.github.com> Co-authored-by: Chen Cong <chock-cong.chen@outlook.com> Co-authored-by: Janusz Dziurzynski <janusz@forserial.org> Co-authored-by: Sky Ao <aoxiaojian@gmail.com> Co-authored-by: lotuc <lotu.c@outlook.com> Co-authored-by: seeflood <349895584@qq.com>
diff --git a/state/mongodb/mongodb.go b/state/mongodb/mongodb.go
@@ -64,6 +64,9 @@ const (
 
 	// mongodb+srv://<server>/<params>
 	connectionURIFormatWithSrv = "mongodb+srv://%s/%s"
+
+	// mongodb+srv://<username>:<password>@<server>/<params>
+	connectionURIFormatWithSrvAndCredentials = "mongodb+srv://%s:%s@%s/%s%s"
 )
 
 // MongoDB is a state store implementation for MongoDB.
@@ -355,6 +358,10 @@ func (m *MongoDB) Query(req *state.QueryRequest) (*state.QueryResponse, error) {
 
 func getMongoURI(metadata *mongoDBMetadata) string {
 	if len(metadata.server) != 0 {
+		if metadata.username != "" && metadata.password != "" {
+			return fmt.Sprintf(connectionURIFormatWithSrvAndCredentials, metadata.username, metadata.password, metadata.server, metadata.databaseName, metadata.params)
+		}
+
 		return fmt.Sprintf(connectionURIFormatWithSrv, metadata.server, metadata.params)
 	}
 
