Add metadata property to configure Batching in Pulsar #1707

saber-wang · 2022-05-05T03:23:16Z

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1671

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[√] Code compiles correctly
[√] Created/updated tests
[√] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: add new metadata to PubSub pulasr docs#2426

…es in Pulsar Signed-off-by: saberwang <[email protected]>

pubsub/pulsar/pulsar.go

shubham1172

LGTM!

Signed-off-by: saberwang <[email protected]>

pubsub/pulsar/pulsar_test.go

shubham1172

Unit tests failing.

Signed-off-by: saberwang <[email protected]>

shubham1172 · 2022-05-05T07:16:48Z

Thank you for the contribution, @saber-wang 🥳!

.gitignore

pubsub/pulsar/pulsar.go

Signed-off-by: saberwang <[email protected]>

.history/pubsub/pulsar/pulsar_20220505155033.go

.gitignore

Signed-off-by: saberwang <[email protected]>

pubsub/pulsar/pulsar.go

shubham1172

As discussed, waiting for settings to be hardcoded.

Signed-off-by: saberwang <[email protected]>

…trib

Signed-off-by: saberwang <[email protected]>

saber-wang · 2022-05-06T08:57:04Z

pubsub/pulsar/pulsar.go

@@ -317,3 +352,14 @@ func (p *Pulsar) formatTopic(topic string) string {
 	}
 	return fmt.Sprintf(topicFormat, persist, p.metadata.Tenant, p.metadata.Namespace, topic)
 }
+
+func formatDuration(durationString string) (time.Duration, error) {


@shubham1172 Is there a better way?

@saber-wang we can make it simpler by always expecting a number.

The metadata can be batchingMaxPublishDelayMs to clearly indicate that it should be in milliseconds.

@berndverst this comment was still pending.

@shubham1172 Need to change to such a design?

That would have been cleaner and simpler but Bernd has already approved/merged this PR. If we have enough consensus, we can create another PR on top to change that I guess.

@shubham1172 I don't have a better idea. I can create a new rp to modify it

Thanks @saber-wang. Let's see what Bernd/@daixiang0 have to say.

pubsub/pulsar/pulsar.go

pubsub/pulsar/metadata.go

Signed-off-by: saberwang <[email protected]>

codecov · 2022-05-07T00:56:55Z

Codecov Report

Merging #1707 (2d8077e) into master (bfd87eb) will increase coverage by 0.02%.
The diff coverage is 45.71%.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   36.37%   36.39%   +0.02%     
==========================================
  Files         166      166              
  Lines       15488    15517      +29     
==========================================
+ Hits         5633     5647      +14     
- Misses       9228     9239      +11     
- Partials      627      631       +4

Impacted Files	Coverage Δ
bindings/azure/cosmosdb/cosmosdb.go	`18.00% <ø> (ø)`
bindings/cron/cron.go	`87.23% <ø> (ø)`
bindings/http/http.go	`87.87% <ø> (ø)`
bindings/kubernetes/kubernetes.go	`17.14% <ø> (ø)`
bindings/localstorage/localstorage.go	`4.95% <0.00%> (-0.17%)`	⬇️
pubsub/azure/servicebus/message.go	`85.84% <ø> (ø)`
state/azure/cosmosdb/cosmosdb.go	`10.91% <0.00%> (ø)`
state/postgresql/postgresdbaccess.go	`38.60% <0.00%> (ø)`
state/redis/redis.go	`35.00% <ø> (ø)`
pubsub/pulsar/pulsar.go	`28.32% <51.85%> (+4.67%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c6735...2d8077e. Read the comment docs.

* Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]>

* Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]>

* Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Chen Cong <[email protected]>

* Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Eddie <[email protected]>

@msfussell

* Update readme of bindings (#1690) Signed-off-by: pigletfly <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Eddie <[email protected]> * Fixing includedHeaders problem with spaces (#1610) Signed-off-by: Ben Kotvis <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Eddie <[email protected]> * Simplify vault token read (#1560) * Simplify vault token get Signed-off-by: zhangchao <[email protected]> * fix lint Signed-off-by: zhangchao <[email protected]> * update tests Signed-off-by: zhangchao <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Eddie <[email protected]> * GH-1609 : Fix for MongoDB Atlas conn strings Added recommended fix in the issue Signed-off-by: Eddie <[email protected]> * updating the comment based on PR feedback Signed-off-by: Eddie <[email protected]> * Initial Certification test for eventhubs binding [incomplete] (#1670) * certification test for eventhubs binding Signed-off-by: tanvigour <[email protected]> * modified go.mod and go.sum Signed-off-by: tanvigour <[email protected]> * Add connection string testing Signed-off-by: tanvigour <[email protected]> * iothub testing Signed-off-by: tanvigour <[email protected]> * address feedback and run test Signed-off-by: tanvigour <[email protected]> * Install Azure CLI IOT hub extension Signed-off-by: Bernd Verst <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> * covering all eventhubs test cases Signed-off-by: tanvigour <[email protected]> * dependency changes after go modtidy-all Signed-off-by: tanvigour <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Eddie <[email protected]> * Use revive instead of golint (#1685) Signed-off-by: pigletfly <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Eddie <[email protected]> * Updated to Go 1.18 (#1697) * Updated to Go 1.18 Signed-off-by: Alessandro (Ale) Segala <[email protected]> * Added go.work file With Go 1.18, this allows gopls (the Go language server used for example in VS Code) to work inside test apps too. See: https://go.dev/doc/tutorial/workspaces Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> * Removed go.work Signed-off-by: ItalyPaleAle <[email protected]> * 💄 Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Eddie <[email protected]> * Add metadata property to configure Batching in Pulsar (#1707) * Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Eddie <[email protected]> * Fix 4529: Ignore Subscribe/Get wrong redis configuration type keys. (#1693) * fix: 4529 Signed-off-by: LaurenceLiZhixin <[email protected]> * Fix: add test does not throw error for wrong type during get all test case of redis configuration Signed-off-by: LaurenceLiZhixin <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Ian Luo <[email protected]> Signed-off-by: Eddie <[email protected]> * Signed-off-by: Eddie Wassef <[email protected]> Fixing leading newline in linter error Signed-off-by: Eddie <[email protected]> * Implment a secret store based on Huawei CSMS (#1710) Signed-off-by: Chen Cong <[email protected]> Co-authored-by: Chen Cong <[email protected]> Signed-off-by: Eddie <[email protected]> * Add yet another missing secret to eventhub binding cert test (#1713) Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Eddie <[email protected]> * Support custom queueEndpoint in Azure Storage Queues (#1692) * Support custom queueEndpoint in Azure Storage Queues Signed-off-by: Janusz Dziurzynski <[email protected]> * run gofmt Signed-off-by: Janusz Dziurzynski <[email protected]> * Add "Url" to JSON field name for clarity Suggested by @msfussell in dapr/docs#2424 Signed-off-by: Janusz Dziurzynski <[email protected]> Signed-off-by: Eddie <[email protected]> * Refactory kafka binding to reuse the kafka common code extracting from kafka pubsub component (#1696) * refactory kafka pubsub code to extract common kafka code for reuse Signed-off-by: Sky Ao <[email protected]> * fix lint;add unit test for subscribeAdapter Signed-off-by: Sky Ao <[email protected]> * move topics filed from internal kafak struct to pubsub kafka struct, since in input binding the topics will confiured in metadata Signed-off-by: Sky Ao <[email protected]> * reuse internal kafka code for bindings Signed-off-by: Sky Ao <[email protected]> * add redis standalone_test back which is delete by mistaken Signed-off-by: Sky Ao <[email protected]> * small code improvement to trigger test Signed-off-by: Sky Ao <[email protected]> * add license headers Signed-off-by: Sky Ao <[email protected]> * try to set disbaleTls to true to verify the kafka connection fail Signed-off-by: Sky Ao <[email protected]> * don't enable consum retry in kafka binding component;if authenticaion is disabled, need not set TLSDisable at the same time; Signed-off-by: Sky Ao <[email protected]> * fix lint Signed-off-by: Sky Ao <[email protected]> Co-authored-by: Loong Dai <[email protected]> Signed-off-by: Eddie <[email protected]> * Add topic metadata for mqtt input binding and support user defined topic for mqtt output binding (#1674) * feat(bindings/mqtt): add data incoming topic to metadata Signed-off-by: lotuc <[email protected]> * feat(bindings/mqtt): support user defined topic on create action Signed-off-by: lotuc <[email protected]> * chore(bindings/mqtt): add integration test and topic response check test Signed-off-by: lotuc <[email protected]> * fix(bindings/mqtt): ignore misspell linting error for word mosquitto Signed-off-by: lotuc <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Eddie <[email protected]> * Expire -> ExpiryInSeconds (#1721) Signed-off-by: seeflood <[email protected]> Signed-off-by: Eddie <[email protected]> * running gofmt -s -w state/mongodb/mongodb.go Signed-off-by: Eddie <[email protected]> * Update mongodb.go Co-authored-by: Wang Bing <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Ben Kotvis <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Taction <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: saber-wang <[email protected]> Co-authored-by: Laurence <[email protected]> Co-authored-by: Ian Luo <[email protected]> Co-authored-by: Chock Chen <[email protected]> Co-authored-by: Chen Cong <[email protected]> Co-authored-by: Janusz Dziurzynski <[email protected]> Co-authored-by: Sky Ao <[email protected]> Co-authored-by: lotuc <[email protected]> Co-authored-by: seeflood <[email protected]>

* Updated to Go 1.18 Signed-off-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * Updated Azure SDKs that are on track2 Includes some minor refactoring of auth code Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * Updated Service Bus components to track2 SDK Co-authored-by: halspang <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * Initial Certification test for eventhubs binding [incomplete] (#1670) * certification test for eventhubs binding Signed-off-by: tanvigour <[email protected]> * modified go.mod and go.sum Signed-off-by: tanvigour <[email protected]> * Add connection string testing Signed-off-by: tanvigour <[email protected]> * iothub testing Signed-off-by: tanvigour <[email protected]> * address feedback and run test Signed-off-by: tanvigour <[email protected]> * Install Azure CLI IOT hub extension Signed-off-by: Bernd Verst <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> * covering all eventhubs test cases Signed-off-by: tanvigour <[email protected]> * dependency changes after go modtidy-all Signed-off-by: tanvigour <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * Use revive instead of golint (#1685) Signed-off-by: pigletfly <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * Updated to Go 1.18 (#1697) * Updated to Go 1.18 Signed-off-by: Alessandro (Ale) Segala <[email protected]> * Added go.work file With Go 1.18, this allows gopls (the Go language server used for example in VS Code) to work inside test apps too. See: https://go.dev/doc/tutorial/workspaces Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> * Removed go.work Signed-off-by: ItalyPaleAle <[email protected]> * 💄 Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * 💄 & 🧹 Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * Add metadata property to configure Batching in Pulsar (#1707) * Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar Signed-off-by: saberwang <[email protected]> * sort field Signed-off-by: saberwang <[email protected]> * [pubsub]fix unit test bug Signed-off-by: saberwang <[email protected]> * remove unrelated changes Signed-off-by: saberwang <[email protected]> * Delete hard coded Metadata Signed-off-by: saberwang <[email protected]> * remove .history Signed-off-by: saberwang <[email protected]> * restore .gitignore Signed-off-by: saberwang <[email protected]> * Hard coding default values and adding 'BatchingMaxPublishDelay' metadata Signed-off-by: saberwang <[email protected]> * fix code format Signed-off-by: saberwang <[email protected]> * formatting code Signed-off-by: saberwang <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * This test can't work with track2 SDKs The methods to create a message with a body are not exported Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * 🧹 Signed-off-by: Alessandro Segala (ItalyPaleAle) <[email protected]> * There's such thing as too much logging Signed-off-by: ItalyPaleAle <[email protected]> * Refactored subscription.go This greatly simplifies certain parts of the code, reducing the number of goroutines and likely improving performance. Performance for end-users improves too as there's no need anymore to pause for 2 seconds every time that we reach `maxActiveMessages`. Additionally, with this change the config options `prefetchCount` and `maxActiveMessagesRecoveryInSec` are removed as unnecessary anymore. Signed-off-by: ItalyPaleAle <[email protected]> * 💄 Signed-off-by: ItalyPaleAle <[email protected]> * Fixed pubsub tests Signed-off-by: ItalyPaleAle <[email protected]> * These packages should have never been upgraded Signed-off-by: ItalyPaleAle <[email protected]> * Ensuring we don't fetch 1 message more than max active Signed-off-by: ItalyPaleAle <[email protected]> * Adding configurable timeout for servicebusqueues operations Signed-off-by: ItalyPaleAle <[email protected]> * Persistent connection for invoking SB queues Signed-off-by: ItalyPaleAle <[email protected]> * Reverted Event Hub SDK update Signed-off-by: ItalyPaleAle <[email protected]> * Revert "Reverted Event Hub SDK update" This reverts commit 212220a. Signed-off-by: ItalyPaleAle <[email protected]> * Fix Azure deploy for users with a first.last email Signed-off-by: ItalyPaleAle <[email protected]> * Added some sleep that should help reduce flakiness in eventhubs binding cert test Signed-off-by: ItalyPaleAle <[email protected]> * Changed servicebusqueue cert test In case of a failure in the handler (ie. users' code), the message should be correctly re-enqueued, which means that messages will be re-delivered later and won't be in order. Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: halspang <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Looong Dai <[email protected]> Co-authored-by: Wang Bing <[email protected]> Co-authored-by: saber-wang <[email protected]>

Add metadata property to configure BatchingMaxSize&batchingMaxMessag…

7bb037c

…es in Pulsar Signed-off-by: saberwang <[email protected]>

saber-wang requested review from a team as code owners May 5, 2022 03:23

shubham1172 reviewed May 5, 2022

View reviewed changes

pubsub/pulsar/pulsar.go Outdated Show resolved Hide resolved

shubham1172 previously approved these changes May 5, 2022

View reviewed changes

sort field

dea0a4c

Signed-off-by: saberwang <[email protected]>

saber-wang dismissed shubham1172’s stale review via dea0a4c May 5, 2022 04:16

shubham1172 approved these changes May 5, 2022

View reviewed changes

shubham1172 reviewed May 5, 2022

View reviewed changes

pubsub/pulsar/pulsar_test.go Outdated Show resolved Hide resolved

shubham1172 suggested changes May 5, 2022

View reviewed changes

[pubsub]fix unit test bug

e80ea4e

Signed-off-by: saberwang <[email protected]>

shubham1172 previously approved these changes May 5, 2022

View reviewed changes

saber-wang mentioned this pull request May 5, 2022

add new metadata to PubSub pulasr dapr/docs#2422

Closed

daixiang0 reviewed May 5, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

daixiang0 reviewed May 5, 2022

View reviewed changes

pubsub/pulsar/pulsar.go Outdated Show resolved Hide resolved

remove unrelated changes

7183e10

Signed-off-by: saberwang <[email protected]>

saber-wang dismissed shubham1172’s stale review via 7183e10 May 5, 2022 07:47

Delete hard coded Metadata

789908c

Signed-off-by: saberwang <[email protected]>

daixiang0 reviewed May 5, 2022

View reviewed changes

.history/pubsub/pulsar/pulsar_20220505155033.go Outdated Show resolved Hide resolved

shubham1172 reviewed May 5, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

saber-wang added 2 commits May 5, 2022 16:47

remove .history

95b7358

Signed-off-by: saberwang <[email protected]>

restore .gitignore

8ec99f2

Signed-off-by: saberwang <[email protected]>

saber-wang force-pushed the master branch from 34629b3 to 8ec99f2 Compare May 5, 2022 08:55

shubham1172 approved these changes May 5, 2022

View reviewed changes

saber-wang mentioned this pull request May 6, 2022

add new metadata to PubSub pulasr dapr/docs#2426

Merged

shubham1172 reviewed May 6, 2022

View reviewed changes

pubsub/pulsar/pulsar.go Show resolved Hide resolved

Merge branch 'master' into master

524e533

shubham1172 suggested changes May 6, 2022

View reviewed changes

Hard coding default values and adding 'BatchingMaxPublishDelay' metadata

b585453

Signed-off-by: saberwang <[email protected]>

Merge branch 'master' of https://github.com/saber-wang/components-con…

1affeae

…trib

saber-wang changed the title ~~Add metadata property to configure BatchingMaxSize&batchingMaxMessages in Pulsar~~ Add metadata property to configure BatchingMaxSize&batchingMaxMessages&BatchingMaxPublishDelay in Pulsar May 6, 2022

fix code format

9f1daf3

Signed-off-by: saberwang <[email protected]>

saber-wang commented May 6, 2022

View reviewed changes

shubham1172 reviewed May 6, 2022

View reviewed changes

pubsub/pulsar/pulsar.go Outdated Show resolved Hide resolved

shubham1172 reviewed May 6, 2022

View reviewed changes

pubsub/pulsar/pulsar.go Show resolved Hide resolved

shubham1172 reviewed May 6, 2022

View reviewed changes

pubsub/pulsar/metadata.go Outdated Show resolved Hide resolved

formatting code

4daff00

Signed-off-by: saberwang <[email protected]>

saber-wang changed the title ~~Add metadata property to configure BatchingMaxSize&batchingMaxMessages&BatchingMaxPublishDelay in Pulsar~~ Add metadata property to configure Batching in Pulsar May 6, 2022

Merge branch 'master' into master

2d8077e

berndverst approved these changes May 7, 2022

View reviewed changes

berndverst merged commit a51de3b into dapr:master May 7, 2022

berndverst added this to the v1.8 milestone May 9, 2022

Add metadata property to configure Batching in Pulsar #1707

Add metadata property to configure Batching in Pulsar #1707

Uh oh!

Conversation

saber-wang commented May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue reference

Checklist

Uh oh!

Uh oh!

shubham1172 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shubham1172 left a comment

Choose a reason for hiding this comment

Uh oh!

shubham1172 commented May 5, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shubham1172 left a comment

Choose a reason for hiding this comment

Uh oh!

saber-wang May 6, 2022

Choose a reason for hiding this comment

Uh oh!

shubham1172 May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1172 May 7, 2022

Choose a reason for hiding this comment

Uh oh!

saber-wang May 7, 2022

Choose a reason for hiding this comment

Uh oh!

shubham1172 May 7, 2022

Choose a reason for hiding this comment

Uh oh!

saber-wang May 7, 2022

Choose a reason for hiding this comment

Uh oh!

shubham1172 May 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented May 7, 2022

Codecov Report

Uh oh!

Uh oh!

saber-wang commented May 5, 2022 •

edited

Loading

shubham1172 May 6, 2022 •

edited

Loading