Skip to content

Allow for both retry handler and retry policy to be used at the same time #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

Allow for both retry handler and retry policy to be used at the same time #25

merged 5 commits into from
Jun 11, 2025

Conversation

TheForbiddenAi
Copy link

@TheForbiddenAi TheForbiddenAi commented Jun 6, 2025 •
edited
Loading

Issue describing the changes in this PR

relates to #1406

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

@TheForbiddenAi TheForbiddenAi mentioned this pull request Jun 6, 2025
Closed
siri-varma
siri-varma approved these changes Jun 9, 2025
View reviewed changes
Copy link

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapr/approvers-java-sdk This PR looks good to me. We can merge it if you folks have no more suggestions.

@TheForbiddenAi TheForbiddenAi mentioned this pull request Jun 10, 2025
Merged
3 tasks
@siri-varma
Copy link

@cicoyle A gentle reminder about this PR. Thank you,

@TheForbiddenAi @javier-aliaga
Switch to ternary statement
d7dcc56 
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: Mason <[email protected]>
@javier-aliaga
Copy link

LGTM

cicoyle
cicoyle approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for updating the version in your PR to save me an extra step!

@cicoyle cicoyle merged commit 152b89f into dapr:main Jun 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicoyle cicoyle cicoyle approved these changes

+2 more reviewers

@siri-varma siri-varma siri-varma approved these changes

@javier-aliaga javier-aliaga javier-aliaga left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheForbiddenAi @siri-varma @javier-aliaga @cicoyle