Skip to content

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented May 13, 2025

Signed-off-by: Cassandra Coyle <[email protected]>
@cicoyle cicoyle requested review from a team as code owners May 13, 2025 17:11
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artur-ciocanu
Copy link
Contributor

@cicoyle I don't think we use this dependency anymore, it used to be required by OkHttpClient, but we are using JDK HttpClient.

@artur-ciocanu
Copy link
Contributor

@cicoyle I have just confirmed, you can remove this dependency:

   <dependency>
      <groupId>com.squareup.okio</groupId>
      <artifactId>okio</artifactId>
      <version>3.11.0</version>
    </dependency>

Signed-off-by: Cassandra Coyle <[email protected]>
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! ❤️

@cicoyle cicoyle merged commit 1e07c77 into dapr:release-1.15 May 13, 2025
9 checks passed
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.15@3e781e1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15    #1356   +/-   ##
===============================================
  Coverage                ?   77.24%           
  Complexity              ?     1764           
===============================================
  Files                   ?      204           
  Lines                   ?     5388           
  Branches                ?      590           
===============================================
  Hits                    ?     4162           
  Misses                  ?      909           
  Partials                ?      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 12, 2025
* update okio

Signed-off-by: Cassandra Coyle <[email protected]>

* rm unused dep

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: siri-varma <[email protected]>
siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 12, 2025
* update okio

Signed-off-by: Cassandra Coyle <[email protected]>

* rm unused dep

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants