-
Notifications
You must be signed in to change notification settings - Fork 223
[1.15] Fix kotlin-stdlib vuln #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Cassandra Coyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cicoyle I don't think we use this dependency anymore, it used to be required by OkHttpClient, but we are using JDK HttpClient. |
@cicoyle I have just confirmed, you can remove this dependency:
|
Signed-off-by: Cassandra Coyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! ❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #1356 +/- ##
===============================================
Coverage ? 77.24%
Complexity ? 1764
===============================================
Files ? 204
Lines ? 5388
Branches ? 590
===============================================
Hits ? 4162
Misses ? 909
Partials ? 317 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* update okio Signed-off-by: Cassandra Coyle <[email protected]> * rm unused dep Signed-off-by: Cassandra Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: siri-varma <[email protected]>
* update okio Signed-off-by: Cassandra Coyle <[email protected]> * rm unused dep Signed-off-by: Cassandra Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: siri-varma <[email protected]>
Cherry-pick this PR to 1.15