-
Notifications
You must be signed in to change notification settings - Fork 223
docs: TLS configuration #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: TLS configuration #1369
Conversation
Signed-off-by: Javier Aliaga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Think we can take this out of draft and merge as is unless you were planning to add more? :)
Lets merge it! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javier-aliaga thanks a lot for documenting this. Could you please add the Java property approach alongside the env vars one.
@@ -40,6 +40,14 @@ If your Dapr instance is configured to require the `DAPR_API_TOKEN` environment | |||
set it in the environment and the client will use it automatically. | |||
You can read more about Dapr API token authentication [here](https://docs.dapr.io/operations/security/api-token/). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javier-aliaga for completeness you should mention that GRPC TLS related configs can be passed either via env vars or Java properties.
Here are the property names corresponding to env vars:
dapr.grpc.tls.insecure
dapr.grpc.tls.ca.path
dapr.grpc.tls.cert.path
dapr.grpc.tls.key.path
I ended up opening this PR to address the lack of documentation and fix the system properties aligning with the env vars. If we like the approach I took in my PR we can close this one out. |
@javier-aliaga could you please close this PR. @cicoyle merged all the necessary changes related to GRPC env vars and System Properties and has updated the docs. |
Closing this since we merged in the above linked PR docs. Thanks for the start on it here! I wanted to pull it out and expand this content. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
============================================
+ Coverage 76.91% 77.57% +0.66%
- Complexity 1592 1776 +184
============================================
Files 145 205 +60
Lines 4843 5472 +629
Branches 562 599 +37
============================================
+ Hits 3725 4245 +520
- Misses 821 907 +86
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Modify docs to document new TLS Configuration for grpc connections
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: