Skip to content

Conversation

mcruzdev
Copy link
Contributor

Description

This pull request aims to align the Java SDK Workflow API woth other languages (Python, C#, etc.)

What this pull request does:

  • Deprecate waitForInstanceStart, getInstanceState and waitForInstanceCompletion.
  • Change the documentation to use the new methods (waitForWorkflowStart, getWorkflowState and waitForWorkflowCompletion)
  • Change test to use the new methods.

Issue reference

Closes #1554

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mcruzdev mcruzdev requested review from a team as code owners September 20, 2025 20:02
Signed-off-by: Matheus Cruz <[email protected]>
Signed-off-by: Matheus Cruz <[email protected]>
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (d759c53) to head (5449651).
⚠️ Report is 224 commits behind head on master.

Files with missing lines Patch % Lines
...a/io/dapr/workflows/client/DaprWorkflowClient.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1560      +/-   ##
============================================
+ Coverage     76.91%   78.43%   +1.51%     
- Complexity     1592     1912     +320     
============================================
  Files           145      215      +70     
  Lines          4843     5833     +990     
  Branches        562      652      +90     
============================================
+ Hits           3725     4575     +850     
- Misses          821      920      +99     
- Partials        297      338      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siri-varma
Copy link
Contributor

@mcruzdev The patch coverage is failing. Looks like some more unit tests are needed.

@siri-varma
Copy link
Contributor

LGTM. Can be merged once the patch succeedes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align getInstanceState and other instance-based APIs with workflow naming
2 participants