-
Notifications
You must be signed in to change notification settings - Fork 224
feat(pubsub): add bulk subscribe support #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add bulk subscribe support #791
Conversation
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
sdk-springboot/src/main/java/io/dapr/springboot/domain/DaprBulkAppResponse.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
…am1172/java-sdk into shubham1172/bulk-subscribe-support
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
sdk-tests/src/test/java/io/dapr/it/methodinvoke/grpc/MethodInvokeIT.java
Outdated
Show resolved
Hide resolved
@shubham1172 One point, potentially |
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Thanks Mukundan, I have removed the |
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
examples/src/main/java/io/dapr/examples/pubsub/http/Publisher.java
Outdated
Show resolved
Hide resolved
sdk/src/test/java/io/dapr/client/domain/BulkAppResponseEntryTest.java
Outdated
Show resolved
Hide resolved
sdk/src/test/java/io/dapr/client/domain/BulkAppResponseTest.java
Outdated
Show resolved
Hide resolved
sdk/src/test/java/io/dapr/client/domain/BulkMessageEntryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
; Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
sdk-springboot/src/main/java/io/dapr/springboot/DaprRuntime.java
Outdated
Show resolved
Hide resolved
if (this.useGrpc) { | ||
assertEquals("UNKNOWN: ", exception.getMessage()); | ||
assertEquals("INTERNAL", exception.getErrorCode()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve the conflicts from master, please. For that, you can just pick the master changes.
sdk/src/main/java/io/dapr/client/domain/BulkPubSubMessageEntry.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/dapr/client/domain/BulkSubscribeAppResponseEntry.java
Show resolved
Hide resolved
Also, resolve conflicts from master, please. |
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
============================================
+ Coverage 77.62% 78.10% +0.48%
- Complexity 1161 1190 +29
============================================
Files 105 111 +6
Lines 3647 3718 +71
Branches 419 424 +5
============================================
+ Hits 2831 2904 +73
+ Misses 603 597 -6
- Partials 213 217 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Description
NOTE: This PR should be only merged once the bulk pubsub feature (2218) is checked-in Dapr. The Dapr reference in build/validate YAMLs must be updated back to
master
.Add a new annotation
@BulkSubscribe
to allow subscribing to events using the Bulk Subscribe API.Issue reference
Please reference the issue this PR will close: #778
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: