Skip to content

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Sep 28, 2022

Description

NOTE: This PR should be only merged once the bulk pubsub feature (2218) is checked-in Dapr. The Dapr reference in build/validate YAMLs must be updated back to master.

Add a new annotation @BulkSubscribe to allow subscribing to events using the Bulk Subscribe API.

Issue reference

Please reference the issue this PR will close: #778

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 shubham1172 marked this pull request as ready for review September 29, 2022 07:19
@shubham1172 shubham1172 requested review from a team as code owners September 29, 2022 07:19
@shubham1172 shubham1172 changed the title [WIP] feat(pubsub): add bulk subscribe support feat(pubsub): add bulk subscribe support Sep 29, 2022
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
…am1172/java-sdk into shubham1172/bulk-subscribe-support
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@mukundansundar mukundansundar dismissed their stale review January 13, 2023 07:53

changes addressed.

@mukundansundar
Copy link
Contributor

@shubham1172 One point, potentially BulkPublishEntry in #789 and DaprBulkMessageEntry can be combined. Based on which PR goes in first both domain objects can be combined.
Also do we need to prefix with Dapr on the domain objects? Like DaprBulkMessage ? Can it just be BulkMessage?

Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172
Copy link
Member Author

@shubham1172 One point, potentially BulkPublishEntry in #789 and DaprBulkMessageEntry can be combined. Based on which PR goes in first both domain objects can be combined. Also do we need to prefix with Dapr on the domain objects? Like DaprBulkMessage ? Can it just be BulkMessage?

Thanks Mukundan, I have removed the Dapr prefix from domain objects.

Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
;

Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
if (this.useGrpc) {
assertEquals("UNKNOWN: ", exception.getMessage());
assertEquals("INTERNAL", exception.getErrorCode());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflicts from master, please. For that, you can just pick the master changes.

@artursouza
Copy link
Contributor

Also, resolve conflicts from master, please.

Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #791 (75111a3) into master (b83661d) will increase coverage by 0.48%.
The diff coverage is 54.54%.

@@             Coverage Diff              @@
##             master     #791      +/-   ##
============================================
+ Coverage     77.62%   78.10%   +0.48%     
- Complexity     1161     1190      +29     
============================================
  Files           105      111       +6     
  Lines          3647     3718      +71     
  Branches        419      424       +5     
============================================
+ Hits           2831     2904      +73     
+ Misses          603      597       -6     
- Partials        213      217       +4     
Impacted Files Coverage Δ
...o/dapr/client/domain/BulkSubscribeAppResponse.java 0.00% <0.00%> (ø)
...r/client/domain/BulkSubscribeAppResponseEntry.java 0.00% <0.00%> (ø)
.../client/domain/BulkSubscribeAppResponseStatus.java 0.00% <0.00%> (ø)
...va/io/dapr/client/domain/BulkSubscribeMessage.java 0.00% <0.00%> (ø)
.../dapr/client/domain/BulkSubscribeMessageEntry.java 0.00% <0.00%> (ø)
...java/io/dapr/springboot/DaprTopicSubscription.java 85.00% <75.00%> (+85.00%) ⬆️
...java/io/dapr/springboot/DaprBeanPostProcessor.java 72.00% <85.00%> (+31.70%) ⬆️
.../src/main/java/io/dapr/springboot/DaprRuntime.java 81.48% <100.00%> (+16.26%) ⬆️
...va/io/dapr/springboot/DaprSubscriptionBuilder.java 48.71% <100.00%> (+13.58%) ⬆️
...ava/io/dapr/springboot/DaprTopicBulkSubscribe.java 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@artursouza artursouza merged commit eb8565c into dapr:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk PubSub implementation
4 participants