This repository was archived by the owner on Feb 22, 2018. It is now read-only.
docs(formatter): edit and update formatter docs #1036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,9 @@ | |||
| part of angular.formatter_internal; | |||
|
|
|||
| /** | |||
| * Allows you to convert a JavaScript object into JSON string. This formatter is | |||
| * mostly useful for debugging. | |||
| * Converts a JavaScript object into a JSON string. | |||
There was a problem hiding this comment.
JS is wrong here -> "an object" ?
There was a problem hiding this comment.
Thanks. Updated.
| * indicates a list of fallback expressions to use when a comparision results in the items | ||
| * being equal. | ||
| * | ||
| * If the expression is explicitly empty(`orderBy:```), the elements are sorted in |
Closed
| @@ -3,7 +3,32 @@ part of angular.formatter_internal; | |||
| typedef dynamic _Mapper(dynamic e); | |||
|
|
|||
| /** | |||
| * Orders the provided [Iterable] by the `expression` predicate. | |||
| * Orders the the elements of an object by a predicate expression. | |||
There was a problem hiding this comment.
object -> iterable (only iterables can be sorted)
naomiblack
added a commit
that referenced
this pull request
May 16, 2014
jbdeboer
pushed a commit
to jbdeboer/angular.dart
that referenced
this pull request
May 21, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.