feat(directive-injector): component directive injector injects parent #1379
Conversation
| DirectiveInjector i; | ||
| ComponentDirectiveInjector cdi; | ||
| InjectorDependentComponent(this.i, this.cdi) { | ||
| expect(i).not.toEqual(cdi); |
There was a problem hiding this comment.
expect(i).toBeAnInstanceOf(DirectiveInjector);
expect(cdi).toBeAnInstanceOf(ComponentDirectiveInjector);
|
IIUC and if this is a "feat" (not a 'fix") the commit message should mention that it is a breaking change as |
|
Adding breaking change line. Note I am not following your comment about "this should be tested" as there is a test. |
|
I think the new behavior should be tested: " |
BREAKING_CHANGE:
When asked for DirectiveInjector, ComponentDirectiveInjector injects
parent. When asked for ComponentDirectiveInjector it injects self.
Before:
MyComponent(DirectiveInjector di) { }
After:
MyComponent(ComponentDirectiveInjector cdi, DirectiveInjector di) { }
where before di = after cdi, before di.parent = after di.
Closes dart-archive#1351
|
Added |
When asked for DirectiveInjector, ComponentDirectiveInjector injects
parent and injects self, when asked for ComponentDirectiveInjector
explicitly.
Closes #1351