This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Allow signing into default profile and enabling extensions #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `signIn` argument to `startWithDebugPort` API. - Add tests. Related: dart-lang/webdev#1490
kevmoo
reviewed
Jan 20, 2022
kevmoo
reviewed
Jan 20, 2022
kevmoo
approved these changes
Jan 21, 2022
kevmoo
reviewed
Jan 21, 2022
kevmoo
approved these changes
Jan 21, 2022
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…ive/browser_launcher#29) * Allow signing into default profile and enabling extensions - Add `signIn` argument to `startWithDebugPort` API. - Add tests. Related: dart-lang/webdev#1490 * Addressed CR comments, fixed test failure * Addressed more CR comments * Addressed CR comments, fixed test flake * Create tem dir for eacch test, better flake fix * Make closing chrome on each test explicit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of the library have requested an option to start chrome signed into the default profile.
Allow signing into default profile and enabling extensions.
signInargument tostartWithDebugPortAPI.Related: dart-lang/webdev#1490