Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Add example to improve pub score. #6

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

kenzieschmoll
Copy link
Contributor

No description provided.

@kenzieschmoll kenzieschmoll requested a review from kevmoo April 26, 2019 21:49
pubspec.yaml Outdated
@@ -1,7 +1,7 @@
name: browser_launcher
description: A standardized way to launch web browsers.

version: 0.1.0-dev
version: 0.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change this to 0.1.1-dev since since this will go out after 0.1.0 – right?

@@ -1,3 +1,3 @@
## 0.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ## 0.1.1 – added example

Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to bump the version to 0.1.1-dev and add a changelog about adding an example

const _googleUrl = 'https://www.google.com/';
const _googleImagesUrl = 'https://www.google.com/imghp?hl=en';

void main() async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return Future<void> here – just to be...good. 😄

Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@kenzieschmoll kenzieschmoll merged commit cd27330 into dart-archive:master Apr 26, 2019
@kenzieschmoll kenzieschmoll deleted the example branch April 26, 2019 22:14
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants