Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

int extension #228

Closed
wants to merge 2 commits into from
Closed

int extension #228

wants to merge 2 commits into from

Conversation

thomassth
Copy link

Similar to dart-lang/core#624

Since https://github.com/felixblaschke/supercharged is stopping active development, I found the rangeTo and until within are both very useful tool to generate numbered iterates quickly, and brings dart to feature parity with other languages. I think they should be included to this package.

@kevmoo
Copy link
Contributor

kevmoo commented Dec 31, 2021

CC @lrhn – not sure how I feel about this.

At a minimum, should have tests!

@thomassth
Copy link
Author

I've added tests now.

@lrhn
Copy link
Contributor

lrhn commented Jan 3, 2022

I'm not totally sold on adding this functionality.

If we do, the naming should be consistent (one is called rangeTo, the other until, so either both or neither should use range), and the implementation might need some tweaking. I'd prefer a an Iterator class which can be inlined by an optimizing compiler where possible, and not allocating a function value for each.

So, I'd say no to this particular implementation, and I'll consider whether we want the functionality or not.
(Discussion should go to dart-lang/core#624).

@lrhn lrhn closed this Apr 20, 2022
@lrhn lrhn reopened this Apr 20, 2022
@lrhn lrhn closed this Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants