This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Fix warnings related to fuzzy arrows. #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will become an arrow in Dart 2.0. See this bug for more context: dart-lang/sdk#29630 I also fixed a couple of unused variable warnings while I was at it. I bumped the version number in the pubspec. This is technically a potentially breaking change because the signatures of createHitmap() and mergeHitmaps() are more precise now. The only code I could find calling that was in flutter_tools and that seems to be happy with the change. If you'd rather I keep the old version, let me know.
|
Thank you, good sir! |
cbracken
approved these changes
Nov 9, 2017
cbracken
added a commit
to cbracken/coverage
that referenced
this pull request
Dec 14, 2017
cbracken
added a commit
that referenced
this pull request
Dec 14, 2017
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Aug 28, 2024
These will become an arrow in Dart 2.0. See this bug for more context: dart-lang/sdk#29630 I also fixed a couple of unused variable warnings while I was at it. I bumped the version number in the pubspec. This is technically a potentially breaking change because the signatures of createHitmap() and mergeHitmaps() are more precise now. The only code I could find calling that was in flutter_tools and that seems to be happy with the change. If you'd rather I keep the old version, let me know.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Aug 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will become an arrow in Dart 2.0. See this bug for more context:
dart-lang/sdk#29630
I also fixed a couple of unused variable warnings while I was at it.
I bumped the version number in the pubspec. This is technically a
potentially breaking change because the signatures of createHitmap() and
mergeHitmaps() are more precise now. The only code I could find calling
that was in flutter_tools and that seems to be happy with the change.
If you'd rather I keep the old version, let me know.