Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Conversation

dkrutskikh
Copy link
Contributor

Add number of instrumented lines 'LF' and number of lines with a non-zero execution count 'LH'

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Add number of instrumented lines 'LF' and number of lines with a non-zero execution count 'LH'
@googlebot
Copy link

CLAs look good, thanks!

@dkrutskikh
Copy link
Contributor Author

@cbracken can you merge this PR?

@kevmoo kevmoo requested a review from cbracken October 10, 2018 22:23
final lines = v.keys.toList()..sort();
lines.forEach((int k) {
buf.write('DA:$k,${v[k]}\n');
});
Copy link
Contributor

@cbracken cbracken Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, would you mind switching this to use a for-loop here rather than .forEach()? (I'm the guilty party on the original)

https://www.dartlang.org/guides/language/effective-dart/usage#avoid-using-iterableforeach-with-a-function-literal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually never mind, I'll follow up and eliminate my previous shameful commit separately ;)

@cbracken
Copy link
Contributor

cbracken commented Oct 12, 2018

LGTM -- thanks for the patch and apologies for missing this earlier!

lgtm

@cbracken cbracken merged commit ffa3166 into dart-archive:master Oct 12, 2018
mosuem pushed a commit to dart-lang/tools that referenced this pull request Aug 28, 2024
Add number of instrumented lines 'LF' and number of lines with a non-zero execution count 'LH'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants