Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Loosen version restriction on package:vm_service now that crasher has been fixed #280

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Dec 3, 2019

@bkonyi bkonyi requested a review from cbracken December 3, 2019 23:15
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.965% when pulling 2e2f1e2 on bump_package_vm_service into 01d4506 on master.

@cbracken
Copy link
Contributor

cbracken commented Dec 4, 2019

In theory the constraint solver could still pick 2.1.2, but I'm not sure that pub provides a mechanism to exclude a version within a range.

@cbracken cbracken merged commit 5880488 into master Dec 4, 2019
@cbracken cbracken deleted the bump_package_vm_service branch December 4, 2019 00:30
mosuem pushed a commit to dart-lang/tools that referenced this pull request Aug 28, 2024
…ge#280)

Re-loosen the dependency on the `vm_service` package from `>=1.0.0 < 2.1.2`
to `>=1.0.0 <3.0.0` now that breakage introduced in version `2.1.2` has been
resolved. Fixed in:
dart-lang/sdk@7a911ce.

Fixes https://github.com/dart-lang/coverage/issues/278.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

vm_service 2.1.2 breaks coverage 0.13.3+1
4 participants