This repository was archived by the owner on Nov 1, 2024. It is now read-only.
fix the reported span for expressions #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonsenft
approved these changes
Jan 31, 2023
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* fix the reported span for expressions * update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
px,pt, ...)Generally it looks like spans are only correct for the start position of a node. For example, for an
Expressionsnode (a list ofExpressions), the span would correspond with the first token from the first expression. We'd need to change how the parser worked in order for this library to be useful for something like producing minimal edits of css.