Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

Use package lints #712

Merged
merged 4 commits into from
May 21, 2021
Merged

Use package lints #712

merged 4 commits into from
May 21, 2021

Conversation

domesticmouse
Copy link
Contributor

Hey Sam,

Is this a path we should go down?

brett

@domesticmouse domesticmouse requested a review from srawlins May 21, 2021 00:50
@google-cla google-cla bot added the cla: yes label May 21, 2021
@srawlins
Copy link
Contributor

I just made this change to two of my own repos 😁 .

When migrating from pedantic, there are 6 rules that are dropped, which we may want to manually list in analysis_options: dart-archive/lints#41

The only interesting one is probably always_declare_return_types, maybe prefer_single_quotes and unawaited_futures.

@domesticmouse
Copy link
Contributor Author

When migrating from pedantic, there are 6 rules that are dropped, which we may want to manually list in analysis_options: dart-lang/lints#41

The only interesting one is probably always_declare_return_types, maybe prefer_single_quotes and unawaited_futures.

I just added always_declare_return_types, prefer_single_quotes and unawaited_futures to analysis_options.yaml.

@domesticmouse domesticmouse merged commit b58ef8b into dart-archive:master May 21, 2021
@domesticmouse domesticmouse deleted the use-pkg-lints branch May 21, 2021 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srawlins srawlins Awaiting requested review from srawlins

Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domesticmouse @srawlins