Operators are not properly checked

[vsmenon]

Adding the following test - see the "should be" cases below:

      class A {
        A operator *(B b) {}
        A operator /(B b) {}
        A operator ~/(B b) {}
        A operator %(B b) {}
        A operator +(B b) {}
        A operator -(B b) {}
        A operator <<(B b) {}
        A operator >>(B b) {}
        A operator &(B b) {}
        A operator ^(B b) {}
        A operator |(B b) {}
      }

      class B {
        A operator -(B b) {}
      }

      foo() => new A();

      test() {
        A a = new A();
        B b = new B();
        var c = foo();
        a = a * b;
        a = a * /*pass should be info:DownCast*/c;
        a = a / b;
        a = a ~/ b;
        a = a % b;
        a = a + b;
        a = a + /*pass should be severe:StaticTypeError*/a;
        a = a - b;
        b = /*severe:StaticTypeError*/b - b;
        a = a << b;
        a = a >> b;
        a = a & b;
        a = a ^ b;
        a = a | b;
        c = (/*pass should be warning:DynamicInvoke*/c + b);
      }

[vsmenon]

More breakage:

double x = 0.0;
x += 1;

fails with a StaticTypeError - we think x + 1 is num (as per spec) and have no place to inject a cast (without rewriting).

The error message is screwy as well (double is not double).

[jacob314]

here's one more case:

class Foo {
int length;
}
var list = [];

var y = 0;
list.forEach((x) => /* DDC:severe: StaticTypeError, Type check failed: y += x.length (num) is not of type int */y += x.length);

Another important case is where the list doesn't have a type. Here inference can't help and we need to make sure the error given to the user is understandable. The error/warning/info should be about a dynamic cast from dynamic to int not that num is not an int.

var list = [];
var y = 0;
list.forEach((x) => /* DDC:severe: StaticTypeError, Type check failed: y += x.length (num) is not of type int */y += x.length);

[jacob314]

int direction *= -1;

•  /\* DDC:severe: StaticTypeError, Type check failed: direction *= -1 (num) is not of type int */direction *= -1;
  

[vsmenon]

One more broken variant:
/* DDC:severe: StaticTypeError, Type check failed: foo[i] += 1 (double) is not of type double */
where foo is Float64List. The error is broken as well here.

[vsmenon]

These should be fixed now.