This repository was archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Support "simple" Closure compilation mode #312
Comments
This was referenced Sep 9, 2015
thanks for collecting all of these!
Nice! Yeah that would work & also would simplify our JsSymbol/Symbol issues.
note: |
This was referenced Sep 14, 2015
ochafik
pushed a commit
that referenced
this issue
Jan 26, 2016
…es in ES5: cannot redefine Function.name/length properties) (issue #312)
ochafik
pushed a commit
that referenced
this issue
Jan 26, 2016
ochafik
pushed a commit
that referenced
this issue
Jan 28, 2016
…es in ES5: cannot redefine Function.name/length properties) (issue #312)
ochafik
pushed a commit
that referenced
this issue
Feb 3, 2016
Closure compiler chokes on super classes that aren't qualified paths. (example: http://goo.gl/5mHC7S) BUG= [email protected] Review URL: https://codereview.chromium.org/1638533004 .
ochafik
pushed a commit
that referenced
this issue
Feb 3, 2016
…or Closure, to avoid ES5->ES6 lowering bug (google/closure-compiler#1460). This is part of the overall "simple closure" effort (issue #312) BUG= [email protected] Review URL: https://codereview.chromium.org/1630963003 .
ochafik
pushed a commit
that referenced
this issue
Feb 3, 2016
…or Closure, to avoid ES5->ES6 lowering bug (google/closure-compiler#1460). This is part of the overall "simple closure" effort (issue #312)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Closure Compiler can almost consume the output of DDC with
--language_in=ECMASCRIPT6_STRICT -O SIMPLE
(and output ES5 code).Here are some blockers:
(fixed by google/closure-compiler@3f54e47)
super
getter calls aren't supported yet (Implement ES6 transpilation of super.getter calls google/closure-compiler#1089).(fixed)
super
method calls make the compiler to crash (Internal error with super method call google/closure-compiler#1125).super
method calls on computed properties crash the compiler (Super calls on computed properties crash the compiler google/closure-compiler#1184)Cannot (re)define local
Object
,Error
classes incore.js
. This can be worked around by attaching the classes to some namespace (see branch closure-qualify):(fixed)
let
often makes the compiler to crash (Internal error with let inside while loop google/closure-compiler#1124). Could be somehow worked around by using var everywhere, but then the hand-written parts of the runtime are an issue.(fixed by e693a00)
"The class in an extends clause must be a qualified name" (see workaround in branch closure-annotations-alias-parent).Cycles in ES6 module imports crash Closure. This can be worked around by using rollup.js to unfold the imports (fixed one blocker in 0.25.4), then running Closure on the result.
Other annoying non-blockers:
Misplaced annotations warning with computed properties (Misplaced annotation warning with computed properties in ES6 classes google/closure-compiler#1126)(Note: "ADVANCED" optimizations are filed under #311)
The text was updated successfully, but these errors were encountered: