Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

calling convention for types that overlap (e.g. Object, Number, String, Boolean) #40

Closed
@jmesserly

Description

@jmesserly

for types where we used JS values directly, we need to ensure calls don't go through JS method dispatch. This is already handled for binary operator call sites (see _isJSBuiltinType) based on an earlier CL, however a bunch of issues remain:

  • Object is not sealed. Those methods need to be overridden too. I think we support == already but not others. Easiest fix might be just to have DartObject that all Dart objects extend.
  • Number/String/Boolean -- we need to declare these methods correctly, and make sure everything is going through the right calling convention (not just binary ops).

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions