Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

remove workaround when V8 arrow functions are fixed #43

Closed
jmesserly opened this issue Feb 12, 2015 · 5 comments
Closed

remove workaround when V8 arrow functions are fixed #43

jmesserly opened this issue Feb 12, 2015 · 5 comments
Assignees
@jmesserly
Labels
dev-compiler-node

Comments

@jmesserly
Copy link
Contributor

V8 tracking bug: https://code.google.com/p/v8/issues/detail?id=2700
for now going to throw a .bind(this) on it
@jmesserly jmesserly self-assigned this Feb 12, 2015
@jmesserly jmesserly added the js label Feb 12, 2015
@jmesserly jmesserly removed their assignment Feb 12, 2015
jmesserly pushed a commit that referenced this issue Feb 12, 2015
workaround for arrow function bind this
1ab9d36 
I filed #43 to track removal of this workaround

[email protected]

Review URL: https://chromereviews.googleplex.com/154077013
@jmesserly jmesserly self-assigned this Jun 2, 2015
@jmesserly
Copy link
Contributor Author

it's fixed! yay

@jmesserly
Copy link
Contributor Author

https://codereview.chromium.org/1169473003/

@jmesserly jmesserly reopened this Sep 8, 2015
@jmesserly
Copy link
Contributor Author

we reverted the fix for this in: 42df558

however, now that node.js 4.0 is out: https://nodejs.org/en/blog/release/v4.0.0/
we can fix this once again.

@jmesserly jmesserly added the task label Sep 8, 2015
@jmesserly
Copy link
Contributor Author

we now require node > 5, I believe, so we can remove this workaround.

@jmesserly
Copy link
Contributor Author

https://codereview.chromium.org/1643523008

@kzhdev kzhdev mentioned this issue Feb 14, 2016
Closed
nex3 pushed a commit to dart-lang/sdk that referenced this issue Aug 31, 2016
workaround for arrow function bind this
f7a5ff4 
I filed dart-archive/dev_compiler#43 to track removal of this workaround

[email protected]

Review URL: https://chromereviews.googleplex.com/154077013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmesserly jmesserly

Labels
dev-compiler-node
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmesserly