This repository was archived by the owner on Feb 22, 2018. It is now read-only.
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
generic methods should be able to override non-generic ones. #459
Closed
Description
Split from #301. Something like this should be supported (or we need to explicitly disallow it):
class B {
Iterable map(f(x)); // (* -> *) -> Iterable<*>
}
class D extends B {
Iterable<T> map<T>(T f(x)); // <T>(* -> T) -> Iterable<T>
}
See comments starting from #301 (comment).
Normally the subtyping relation is fine, because implicit instantiation can be generated as an explicit instantiation in the generated JavaScript. However for a method override, we don't have any way to express that. It'd be a little unfortunate if all generic method calls used a different calling convention, but perhaps it's unavoidable.
Activity
Andersmholmgren commentedon Feb 22, 2016
I am already hitting this in the wild. As the annotations are missing on the Iterable methods of the collections package, those methods are not considered to be overriding those in the core dart package. So I get warnings for them
jmesserly commentedon Feb 22, 2016
Ah, that sounds like the reverse problem:
Having a non-generic override a generic is not allowed in either strong or normal mode. If you think about it, it's kind of like optional arguments. You can add optional parameters in a subtype, but you can't take parameters away:
The short term fix is to annotate the collections package.
We've discussed doing inference. Given my first example, we could conclude that
D.map
needs a type parameter, which would make itD.map<T>
. However the return type ofIterable<dynamic>
is also problematic, unless we can conclude it too should beIterable<T>
. But we're unsure if this kind of inference is a good idea, as it's sort of analogous to inferring a missing function parameter :)jmesserly commentedon Sep 13, 2016
This issue was moved to dart-lang/sdk#27334