Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

get sdk libraries working #58

Closed
jmesserly opened this issue Feb 19, 2015 · 4 comments
Closed

get sdk libraries working #58

jmesserly opened this issue Feb 19, 2015 · 4 comments

Comments

@jmesserly
Copy link
Contributor

SDK libraries (dart:*) are not remotely close to working in JS. This is a tracking bug.

@jmesserly jmesserly added the js label Feb 19, 2015
jmesserly pushed a commit that referenced this issue Feb 20, 2015
Moves: test/sdk --> tool/input_sdk_src
Also moves: test/sdk/lib/_internal/js_lib --> tool/input_sdk_patch
we'll eventually need to customize that code

Adds tool/patch_sdk.dart, an offline transformation step that produces: test/generated_sdk

Essentially this merges the "external" declarations and the @patch syntactically. There's a comment in tool/patch_sdk.dart explaining the rationale behind this approach.

There's still *lots* to do in the generated code. This does none of that. The only new code is tool/patch_sdk.dart and the minimum changes to test/codegen_test.dart and js_codegen.dart to get test.sh running and debuggable.

Tracking bug for SDK is #58

[email protected], [email protected]

Review URL: https://chromereviews.googleplex.com/157137013
@jmesserly
Copy link
Contributor Author

the primitive types might be a good place to start: Object, bool, int, double, String. And List, Map (those a a little different, as they probably kind of work already). See also #40.

Currently Object is generating non-sensical class Object extends dart.Object :)

@jmesserly
Copy link
Contributor Author

CC @vsmenon

@jmesserly
Copy link
Contributor Author

@jmesserly
Copy link
Contributor Author

there's probably still issues (e.g. mirrors), but we can track them on their own. It should mostly work now.

nex3 pushed a commit to dart-lang/sdk that referenced this issue Aug 31, 2016
Moves: test/sdk --> tool/input_sdk_src
Also moves: test/sdk/lib/_internal/js_lib --> tool/input_sdk_patch
we'll eventually need to customize that code

Adds tool/patch_sdk.dart, an offline transformation step that produces: test/generated_sdk

Essentially this merges the "external" declarations and the @patch syntactically. There's a comment in tool/patch_sdk.dart explaining the rationale behind this approach.

There's still *lots* to do in the generated code. This does none of that. The only new code is tool/patch_sdk.dart and the minimum changes to test/codegen_test.dart and js_codegen.dart to get test.sh running and debuggable.

Tracking bug for SDK is dart-archive/dev_compiler#58

[email protected], [email protected]

Review URL: https://chromereviews.googleplex.com/157137013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

1 participant