Runtime error on static field named 'name'

[vsmenon]

class Field {
  static const name = 'Foo';
}

void main() {
  print(Field.name);
}

triggers this at runtime:

TypeError: Cannot assign to read only property 'name' of function 'class Field extends core.Object {}'

[vsmenon]

Looks like we don't check statics for conflicts in _emitMemberName.

[jmesserly]

Huh. I could swear this used to work. :)

We need to use Object.defineProperty to define it. I think we used to send these down the lazy field path, which uses defineProperty, so it worked. It would also be fine to Object.defineProperty(Field.prototype, 'name', { value: 'Foo' }); ... the laziness is not important, only that we use defineProperty.

[vsmenon]

Should we be overwriting name? We could rename it (as we'd do with constructor I think).

Alternatively, we could revisit putting statics here.

[jmesserly]

Yeah we shouldn't rename it. It's equivalent to this perfectly legal ES6 code:

class Field {
  static get name() { return 'Foo'; }
}

[smanilov]

I'm not sure I can reproduce this. (Update: I can, leaving this comment for future reference.)

I'm invoking DDC like this:

dartdevc.dart compile -o foo bug.dart

where bug.dart contains the code from the initial comment.

[smanilov]

My problem was I was not actually running the code.

Explanation on how to run the code here: #485

Running the code as explained in the linked bug reproduces the error.