Spurious Downcast info messages for const.

[jacob314]

I don't think this code should be generating a downcast. BAR should have static type String.

Repo:

class Foo {
  static const BAR = 'hi';
}

class Baz {
  String bla = Foo.BAR; // Info: DownCast
}

Note this seems to impact all const and final fields. Fixing this bug will fix a large number of the DownCasts.

[vsmenon]

Example should read Foo.BAR in the Baz class. BAR needs to be declared as a String to avoid the cast ... or we need inference.

[sigmundch]

FYI - I went ahead and applied Vijay's change to the code snippet in Jacob's post.

I think we should definitely do inference of const expressions. Note that if you do: print(Foo.BAR.runtimeType) you'll always get String.

[jmesserly]

I'll take a look

[jmesserly]

@sigmundch is this working now?

[sigmundch]

yes, this is now fixed. transitive inference between consts is still in the works though :)