Skip to content
This repository was archived by the owner on Jan 17, 2024. It is now read-only.

Undo bump to 0.1.4 #19

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Undo bump to 0.1.4 #19

merged 4 commits into from
Oct 31, 2019

Conversation

dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Oct 25, 2019

Package stable versions should only depend on sdk stable versions.

Package stable versions should only depend on sdk stable versions.
@@ -0,0 +1,18 @@
import 'dart:ffi';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a license header will make that header show up on the pub website. For example in package:http it is omitted: https://pub.dev/packages/http#-example-tab-.

@mit-mit
Copy link
Contributor

mit-mit commented Oct 31, 2019

Rather than undoing this, I think we need update this to depend on 2.6 stable, and then publish 0.1.4 next week

@dcharkes
Copy link
Contributor Author

We cannot depend on 2.6 stable, yet.

I'll make a stable release next week that will depend on 2.6 stable.

The problem is that packages should not have stable versions depend on SDK dev versions. So instead, this should have been 0.1.3-dev4. As by pub versioning logic.

@mkustermann
Copy link

mkustermann commented Oct 31, 2019

As I argued before, we could take the 10 points scoring hit on pub.dev and publish right now with a sdk: ">= 2.6.0-dev.8.2". Once pub.dev uses the new stable the 10 points will come back automatically.

Advantage: We can have all packages ready and usable before D26 is out the door - instead of trying to do all of this after D26 is out the door.

@mit-mit
Copy link
Contributor

mit-mit commented Oct 31, 2019

Martin and & discussed: In this case 2.6 is close, we can go ahead and depend on that. @dcharkes can you please update this repo and get the PR landed; then I'll run pub publish when 2.6 goes out.

@dcharkes
Copy link
Contributor Author

Landing this, and opening a new PR that bumps package:ffi to 0.1.3 (stable) and depends on Dart 2.6.0 stable.

@dcharkes dcharkes merged commit de89e5b into master Oct 31, 2019
@dcharkes dcharkes deleted the dcharkes-patch-2 branch October 31, 2019 11:55
dcharkes added a commit to dart-lang/native that referenced this pull request Jan 16, 2024
Package stable versions should only depend on sdk stable versions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants