This repository was archived by the owner on Jan 17, 2024. It is now read-only.
Minor Utf8.strlen() improvement #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in dart-archive#61, using indexOf(0) to search the zero byte has a bit less overhead than indexWhere(closure).
dcharkes
approved these changes
Nov 18, 2020
lrhn
reviewed
Nov 18, 2020
| @@ -26,7 +26,7 @@ class Utf8 extends Struct { | |||
| static int strlen(Pointer<Utf8> string) { | |||
| final Pointer<Uint8> array = string.cast<Uint8>(); | |||
| final Uint8List nativeString = array.asTypedList(_maxSize); | |||
| return nativeString.indexWhere((char) => char == 0); | |||
There was a problem hiding this comment.
I'd also check if UTF-16 had the same issue.
There was a problem hiding this comment.
Utf16 is missing strlen(). Would it have to create a String to scan the code units? Something like String.fromCharCodes(cstr.asTypedList()).length?
There was a problem hiding this comment.
My bad, there is no strlen there because UTF-16 only goes from string to bytes, not the other way.
(I thought I saw two strlen implementations at some point. Maybe I was just looking at before and after a CL 🤭).
dcharkes
pushed a commit
to dart-lang/native
that referenced
this pull request
Jan 16, 2024
As suggested in dart-archive/ffi#61, using indexOf(0) to search the zero byte has a bit less overhead than indexWhere(closure).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #61, using indexOf(0) to search the zero byte has a bit
less overhead than indexWhere(closure).