You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 28, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md?
Version 3.1.0-dev.0? It's backwards compatible except for the version-bump to Dart 2.14 when we flip it back to stable. And we can release 3.0.x bugfixes if we need to in the mean time.
Would we need to publish 4.0.0 for dart 2.14 when it lands in stable? In that case we probably should use 4.0.0-dev.0.
No, it would be fine to publish 3.1.0 for dart 2.14 as long as we satisfy the following constraints:
We don't change the public Dart API in lib/*.dart in a non-breaking way.
We don't change the command line interface of bin/*.dart in a non-breaking way.
Non-breaking with API is defined as: if behavior observably changes. However, with the exception of thrown Errors. So you could be throwing an UnimplementedError in 3.0.0 and have it implemented in 3.1.0.
In the same way, we refuse the generate unions in 3.0.0 (analogous to throwing Errors in the API), and we implement it in 3.1.0.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/native#358