Skip to content
This repository was archived by the owner on Jan 28, 2024. It is now read-only.

Check that property types aren't incomplete #415

Merged
merged 8 commits into from
Jul 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@ void _parseProperty(clang_types.CXCursor cursor) {
final itf = _interfaceStack.top.interface;
final fieldName = cursor.spelling();
final fieldType = cursor.type().toCodeGenType();

if (fieldType.isIncompleteCompound) {
_logger.warning('Property "$fieldName" in instance "${itf.originalName}" '
'has incomplete type: $fieldType.');
return;
}

final dartDoc = getCursorDocComment(cursor);

final propertyAttributes =
Expand Down
9 changes: 8 additions & 1 deletion test/native_objc_test/bad_method_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,18 @@ void main() {
generateBindingsForCoverage('bad_method');
});

test("Test methods that weren't skipped", () {
test("Test incomplete struct methods that weren't skipped", () {
final obj = BadMethodTestObject.new1(lib);
final structPtr = obj.incompletePointerReturn();
expect(structPtr.address, 1234);
expect(obj.incompletePointerParam_(structPtr), 1234);
});

test("Test bit field methods that weren't skipped", () {
final obj = BadMethodTestObject.new1(lib);
final bitFieldPtr = obj.bitFieldPointerReturn();
expect(bitFieldPtr.address, 5678);
expect(obj.bitFieldPointerParam_(bitFieldPtr), 5678);
});
});
}
20 changes: 20 additions & 0 deletions test/native_objc_test/bad_method_test.m
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@

struct IncompleteStruct;

struct BitField {
int x:3;
int y:12;
};

@interface BadMethodTestObject : NSObject {
}

Expand All @@ -14,6 +19,13 @@ - (struct IncompleteStruct*)incompletePointerReturn; // Not skipped.
- (int64_t)incompleteParam:(struct IncompleteStruct)x; // Skipped.
- (int64_t)incompletePointerParam:(struct IncompleteStruct*)x; // Not skipped.

- (struct BitField)bitFieldReturn; // Skipped.
- (struct BitField*)bitFieldPointerReturn; // Not skipped.
- (int64_t)bitFieldParam:(struct BitField)x; // Skipped.
- (int64_t)bitFieldPointerParam:(struct BitField*)x; // Not skipped.

@property struct BitField bitFieldProperty; // Skipped.

@end

@implementation BadMethodTestObject
Expand All @@ -26,4 +38,12 @@ - (int64_t)incompletePointerParam:(struct IncompleteStruct*)x {
return (int64_t)x;
}

- (struct BitField*)bitFieldPointerReturn {
return (struct BitField*)5678;
}

- (int64_t)bitFieldPointerParam:(struct BitField*)x {
return (int64_t)x;
}

@end