This repository was archived by the owner on Jan 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change how method return types are parsed
dcharkes
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How cool is this! 😎
Please also add it as test in https://github.com/dart-lang/ffigen/tree/objc_example/test/example_tests so that we run it locally when doing dart test
and it's run on the CI.
It is recommended that you filter out just about everything you're not | ||
interested in binding (see the ffigen config in [pubspec.yaml](./pubspec.yaml)). | ||
Virtually all Objective C libraries depend on Apple's internal libraries, which | ||
are huge. Filtering can reduce the generated bindings from millions of lines to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha 😄
The example test is failing because the details of the output are going to depend on the version of the libraries that the github bot has. So instead of doing an exact string comparison, I'm going to just grep for each of the classes and methods I'm using and make sure they exist. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example that uses the AVFAudio framework to play audio files.
Fixes dart-lang/native#245